[sdk/nodejs] Add explicit dependency on @opentelemetry/instrumentation #13278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node.js SDK makes use of `@opentelemetry/instrumentation` directly in https://github.com/pulumi/pulumi/blob/2a69c252410a2d6ffd0bf48dc2c215f51317da0c/sdk/nodejs/cmd/run/tracing.ts#L24, but it is not specified as an explicit dependency in `package.json` -- we're relying on the indirect dependency from `@opentelemetry/instrumentation-grpc`. This can break monorepo setups using npm workspaces. If there is another version of `@opentelemtry/instrumentation`, it is not hoisted for use by the Pulumi program, resulting in pulumi crashing with `error: Error: Cannot find module '@opentelemetry/instrumentation'`. This change fixes this by explicitly declaring the version of `@opentelemetry/instrumentation` the SDK needs in `package.json`.
Changelog[uncommitted] (2023-06-24)Bug Fixes
|
Frassle
approved these changes
Jul 11, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js SDK makes use of
@opentelemetry/instrumentationdirectly inpulumi/sdk/nodejs/cmd/run/tracing.ts
Line 24 in 2a69c25
package.json-- we're relying on the indirect dependency from@opentelemetry/instrumentation-grpc.This can break monorepo setups using npm workspaces. If there is another version of
@opentelemtry/instrumentation, it is not hoisted for use by the Pulumi program, resulting in pulumi crashing witherror: Error: Cannot find module '@opentelemetry/instrumentation'.This change fixes this by explicitly declaring the version of
@opentelemetry/instrumentationthe SDK needs inpackage.json.Fixes #13104