Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl/binder] Propagate SkipRangeTypechecking option down to components' programs #13493

Merged
merged 1 commit into from Jul 14, 2023

Conversation

Zaid-Ajaj
Copy link
Contributor

Description

The option was added only for top level programs but it should be propagated to component programs too.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Zaid-Ajaj Zaid-Ajaj added the area/codegen SDK-gen, program-gen, convert label Jul 14, 2023
@Zaid-Ajaj Zaid-Ajaj requested a review from a team July 14, 2023 17:02
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2023-07-14)

Miscellaneous

  • [programgen] Propagate SkipRangeTypechecking option down to program components
    #13493

Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@Zaid-Ajaj
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 86a2403 into master Jul 14, 2023
50 checks passed
@bors bors bot deleted the zaid/skip-range-typecheck-for-components branch July 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants