codegen/go: Implement pux.Input[T] for generated types #13510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Changelog[uncommitted] (2023-08-28)Features
|
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
80476a2
to
89c5dbb
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
643aafb
to
3025e09
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
2 times, most recently
from
e69fbc1
to
3e986a3
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
3025e09
to
4693c45
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
3e986a3
to
569046b
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
4693c45
to
975d25c
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
569046b
to
b8d4da5
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
975d25c
to
fa66217
Compare
abhinav
changed the title
abhinav
changed the title
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
b8d4da5
to
eec7d43
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
fa66217
to
eb75b35
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
eec7d43
to
7ff4b2c
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
eb75b35
to
154ebe8
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
3 times, most recently
from
ea90f71
to
4aaad1b
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
154ebe8
to
deb416c
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
4aaad1b
to
3019597
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
deb416c
to
c5629e6
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
3019597
to
46e40ea
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
c5629e6
to
3cdf5c3
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
46e40ea
to
8aa317c
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
3cdf5c3
to
9a1be4a
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
8aa317c
to
a4e16f0
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
9a1be4a
to
69e1609
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
a4e16f0
to
dcddeff
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
69e1609
to
fd32ba2
Compare
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
dcddeff
to
2e08486
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
fd32ba2
to
118e2b6
Compare
Zaid-Ajaj
approved these changes
Aug 24, 2023
abhinav
force-pushed
the
abhinav/go-generics-pulumix
branch
from
2e08486
to
d15c02d
Compare
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
118e2b6
to
4d67a9b
Compare
This was referenced Aug 24, 2023
For generated types that impleemnt `pulumi.Output`, or those that implement `pulumi.Input` with a means of converting themselves to a `pulumi.Output`, also generate `ToOutput(context.Context) pux.Output[..]` to satisfy the `pux.Input[T]` interface. This allows all these generated types to be used with `pux.Apply` and other type-safe generic APIs per #13057. Resolves #13587
Regenerates code based on prior codegen changes.
abhinav
force-pushed
the
abhinav/go-generics-codegen
branch
from
4d67a9b
to
c71f3b1
Compare
t0yv0
added a commit
to pulumi/pulumi-azure-native
that referenced
this pull request
Sep 22, 2023
Recent changes to SDK generation cause ubuntu-latest jobs to fail sporadically, with the likely root
cause being out of resources (disk or memory).
The most likely culprit for additional resource requirements is:
https://github.com/pulumi/pulumi/releases/tag/v3.80.0
Specifically this feature:
[sdkgen/go] Generate types that are compatible with sdk/go/pulumix's type-safe APIs (pulumi/pulumi#13510)
The workaround is to use a custom pulumi-ubuntu-8core runner that has more resources available.
Fixes #2767, #2768.
t0yv0
added a commit
to pulumi/pulumi-azure-native
that referenced
this pull request
Sep 22, 2023
Recent changes to SDK generation cause ubuntu-latest jobs to fail
sporadically, with the likely root cause being out of resources (disk or
memory).
The most likely culprit for additional resource requirements is:
https://github.com/pulumi/pulumi/releases/tag/v3.80.0
Specifically this feature:
[sdkgen/go] Generate types that are compatible with sdk/go/pulumix's
type-safe APIs (pulumi/pulumi#13510)
The workaround is to use a custom pulumi-ubuntu-8core runner that has
more resources available.
Fixes #2767, #2768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For generated types that impleemnt
pulumi.Output,or those that implement
pulumi.Inputwith a means of convertingthemselves to a
pulumi.Output,also generate
ToOutput(context.Context) pux.Output[..]to satisfy the
pux.Input[T]interface.This allows all these generated types to be used with
pux.Applyand other type-safe generic APIs per #13057.
Resolves #13587