Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReplaceOnChanges being dropped in schema marshalling #13519

Merged
merged 1 commit into from Jul 18, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Jul 18, 2023

Description

Fixes #13492.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works - No, we'll cover this with Add roundtrip tests for schema json #13080, but that's a large amount of work. This is a quick fix in now to unblock providers.
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Jul 18, 2023

Changelog

[uncommitted] (2023-07-18)

Bug Fixes

  • [sdkgen/{go,nodejs}] Fix ReplaceOnChanges being dropped in Go and NodeJS codegen.
    #13519

@Frassle Frassle force-pushed the fraser/fixReplaceOnChanges branch from 11f87eb to dd376a7 Compare July 18, 2023 13:20
@Frassle Frassle requested a review from a team July 18, 2023 13:20
@Frassle
Copy link
Member Author

Frassle commented Jul 18, 2023

bors merge

@abhinav
Copy link
Contributor

abhinav commented Jul 18, 2023

We should probably add a codegen test case for this case?
There appears to be a codegen/testing/test thing that uses replaceOnChanges but that doesn't look like it caught this.

@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6a7064f into master Jul 18, 2023
50 checks passed
@bors bors bot deleted the fraser/fixReplaceOnChanges branch July 18, 2023 18:51
@Frassle
Copy link
Member Author

Frassle commented Jul 18, 2023

We should probably add a codegen test case for this case?

This will get covered with matrix testing, I'm ok with just fixing this and getting it out to providers for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen is dropping replaceOnChanges within TS and Go SDKs
4 participants