A few fixes for pulumi logs
#13588
Merged
A few fixes for pulumi logs
#13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While many of the most fundamental limitations of `pulumi logs` are still dependent on moving this code out of pulumi/pulumi and into pulumi-aws and other resource providers (#608), this PR implements a few more tactical fixes which improve some common scenarios. Fixes #2665. Fixes #1926. Fixes #3947.
For AWS resources, use the resource's provider's outputs instead of stack config to construct the AWS session.
Changelog[uncommitted] (2023-07-27)Bug Fixes
|
lukehoban
force-pushed
the
lukehoban/logsfixes
branch
from
374c2df
to
ad63ef2
Compare
Frassle
reviewed
Jul 26, 2023
Frassle
approved these changes
Jul 27, 2023
Co-authored-by: Fraser Waters <fraser@pulumi.com>
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While many of the most fundamental limitations of
pulumi logsare still dependent on moving this code out of pulumi/pulumi and into pulumi/pulumi-aws and other resource providers (#608), this PR implements a few more tactical fixes which improve some common scenarios.Unfortunately, this whole area of the code is largely untested, in part because we didn't want to add a dependency on AWS in this layer (yet another reason we really want to do #608). We could choose to further violate this layering and add tests here that use
pulumi-awsto deploy Pulumi resources and then test them against this AWS operations provider.In the meantime, I have manually validated fixes for the following issues.
Fixes #2665.
Fixes #1926.
Fixes #3947.
Fixes #1828.