[program-gen] Normalize the declaration name of generated resource components

[Zaid-Ajaj]

This PR adds a new function DeclarationName() to PCL components which is then used as the name of the component inside of the code, distinguishing it from the file name where it lives. The function returns a valid and idiomatic name to be used and references in the generated code for all of the language generators.

For example if you have a component of which its source code files live ./some-component then the declaration name for that component would be SomeComponent etc.

Fixes #13151

Checklist

• I have run make tidy to update any new dependencies
• I have run make lint to verify my code passes the lint check
  • I have formatted my code using gofumpt

• I have added tests that prove my fix is effective or that my feature works

• I have run make changelog and committed the changelog/pending/<file> documenting my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

[pulumi-bot]

Changelog

[uncommitted] (2023-07-27)

Bug Fixes

• [programgen/{dotnet,go,nodejs,python}] Normalize the declaration name of generated resource components
  #13606

[Frassle]

This looks reasonable, although part of me wonders if we should be making PCL strict about component folder names instead?
Like if we said a component folder had to be a PCL identifier ([A-Za-z][A-Za-z0-9_]*) then it would be up on the converters to normalize names in a way that makes sense to them.
Is there a good reason to put this automapping in PCL binder rather than PCL writers?

[Zaid-Ajaj]

Is there a good reason to put this automapping in PCL binder rather than PCL writers?

Right now, all the language converters use the same logic in the DeclarationName() function so I figured it makes sense to move it to a common place. That said, it didn't have to be a PCL thing, it could have been in a module i.e. naming.DeclarationName(component.DirPath()). It is not really part of the binder either.

The only benefit about making PCL more strict about folder names is simplifying the logic inside DeclarationName and moving complexity inside the {lang}-to-PCL converters. I don't feel strongly about the latter tbh since DeclarationName is pretty simple as is

[Frassle]

Reasonable. I'll ok this for now, feels like something we might revisit around names in our intermediate formats in the future though.

[Zaid-Ajaj]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• bors-ok