Adds two new CLI features - search and AI search #13611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-08-21)Features
|
abhinav
reviewed
Jul 27, 2023
kpitzen
force-pushed
the
KP/AddsSearchCLICommands
branch
3 times, most recently
from
c33e668
to
261fb28
Compare
kpitzen
changed the title
|
New version looks much better. No obvious style/design issues to point out. |
kpitzen
force-pushed
the
KP/AddsSearchCLICommands
branch
2 times, most recently
from
5f802a6
to
7630544
Compare
abhinav
reviewed
Aug 2, 2023
kpitzen
force-pushed
the
KP/AddsSearchCLICommands
branch
2 times, most recently
from
cbe4499
to
a2ead05
Compare
blampe
reviewed
Aug 7, 2023
kpitzen
force-pushed
the
KP/AddsSearchCLICommands
branch
from
63dd709
to
1424dd2
Compare
justinvp
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
For CLI command changes, it'd be awesome to see a screenshot (or gif or https://asciinema.org) in the PR description showing off the usage.
Some comments, but LGTM otherwise.
Adds initial (not-totally-functional) pulumi search implementation
Still TODO: - Validate users' ability to call this endpoint - Iterate on naive search syntax to be a bit more compatible with Pulumi Finalize interface
Removes debugging print statements Remaining TODO: - Decouple this command from the context of a Pulumi project - Improve rendering logic to make results more readable - Add user interaction for things like pagination, etc
Moves them to only the httpstate backend to reduce cross-contamination
kpitzen
force-pushed
the
KP/AddsSearchCLICommands
branch
from
1424dd2
to
3960da2
Compare
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial pulumi search implementation
Description
Fixes #13489
Fixes #12868
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change