update aws-sdk to sso session supported version #13619

TheFynx · 2023-07-28T17:30:42Z

Description

Allows for the use of sso-session backed AWS Profiles

Log out of cloud

❯ ~/.pulumi-dev/bin/pulumi logout
Logged out of https://app.pulumi.com

Try to log in with awssdk=v2 with sso-session profile, existing error

❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile'
error: problem logging in: unable to open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: profile "AwsProfile" is configured to use SSO but is missing required configuration: sso_region, sso_start_url

Try to log in with awssdk=v3 with sso-session profile, success

❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile'
Logged in to levi-framework as levi (s3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile)

Fixes #13142

Checklist

I have run make tidy to update any new dependencies
I have run make lint to verify my code passes the lint check
- I have formatted my code using gofumpt

I have added tests that prove my fix is effective or that my feature works
- Notes: Unsure if tests are needed to do a package update

I have run make changelog and committed the changelog/pending/<file> documenting my change

Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

github-actions · 2023-07-28T17:31:07Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

pulumi-bot · 2023-07-28T17:31:36Z

Changelog

[uncommitted] (2023-08-06)

Miscellaneous

[sdk/go] Updates aws-sdk-go to 1.44.298 to enable support for sso-session link AWS profiles

lukehoban · 2023-08-05T21:52:58Z

/run-acceptance-tests
Please view the results of the acceptance tests Here

lukehoban

Thanks for the PR.

I believe the config changes are unrelated and unneeded for this PR? They also seem to be causing test failures per https://github.com/pulumi/pulumi/actions/runs/5772945578/job/15648531383#step:34:734.

Would love to separate those out so we can merge the dependency update.

lukehoban · 2023-08-05T23:21:48Z

sdk/go/pulumi/config/require.go

@@ -29,29 +29,21 @@ func failf(format string, a ...interface{}) {
 	panic(fmt.Errorf(format, a...))
 }

-func require(ctx *pulumi.Context, key string, secret bool, use, insteadOf string) string {
+func require(ctx *pulumi.Context, key, use, insteadOf string) string {


These changes seem unrelated? Should they be backed out of this PR?

I have no idea how that got changed. I followed the contributing docs and that showed up changed after running the make commands. I included it since it said it was autogenerated. I can revert it to what's in the master branch

github-actions · 2023-08-06T00:01:41Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2023-08-06T00:02:41Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

lukehoban · 2023-08-06T02:25:05Z

/run-acceptance-tests
Please view the results of the acceptance tests Here

Frassle

Update looks fine to me and tests seem happy.

bors merge

13619: update aws-sdk to sso session supported version r=Frassle a=TheFynx  # Description Allows for the use of sso-session backed AWS Profiles - Log out of cloud ```bash ❯ ~/.pulumi-dev/bin/pulumi logout Logged out of https://app.pulumi.com ``` - Try to log in with awssdk=v2 with sso-session profile, existing error ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile' error: problem logging in: unable to open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: profile "AwsProfile" is configured to use SSO but is missing required configuration: sso_region, sso_start_url ``` - Try to log in with awssdk=v3 with sso-session profile, success ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile' Logged in to levi-framework as levi (s3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile) ``` Fixes #13142 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt`  - [ ] I have added tests that prove my fix is effective or that my feature works - Notes: Unsure if tests are needed to do a package update  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version  Co-authored-by: Levi Smith <levithegeek@gmail.com> Co-authored-by: Levi Smith <levi@fynx.me>

bors · 2023-08-07T15:43:04Z

Build failed:

bors-ok

TheFynx · 2023-08-10T18:13:30Z

@Frassle what exactly failed here? It's not overly clear.

Frassle · 2023-08-10T18:33:59Z

Hmm not sure doesn't show anything as failed, lets hope something transient and try again

bors retry

13619: update aws-sdk to sso session supported version r=Frassle a=TheFynx  # Description Allows for the use of sso-session backed AWS Profiles - Log out of cloud ```bash ❯ ~/.pulumi-dev/bin/pulumi logout Logged out of https://app.pulumi.com ``` - Try to log in with awssdk=v2 with sso-session profile, existing error ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile' error: problem logging in: unable to open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: profile "AwsProfile" is configured to use SSO but is missing required configuration: sso_region, sso_start_url ``` - Try to log in with awssdk=v3 with sso-session profile, success ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile' Logged in to levi-framework as levi (s3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile) ``` Fixes #13142 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt`  - [ ] I have added tests that prove my fix is effective or that my feature works - Notes: Unsure if tests are needed to do a package update  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version  Co-authored-by: Levi Smith <levithegeek@gmail.com> Co-authored-by: Levi Smith <levi@fynx.me>

bors · 2023-08-10T19:52:23Z

Build failed:

bors-ok

Frassle · 2023-08-10T19:59:27Z

bors retry

13619: update aws-sdk to sso session supported version r=Frassle a=TheFynx  # Description Allows for the use of sso-session backed AWS Profiles - Log out of cloud ```bash ❯ ~/.pulumi-dev/bin/pulumi logout Logged out of https://app.pulumi.com ``` - Try to log in with awssdk=v2 with sso-session profile, existing error ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile' error: problem logging in: unable to open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: open bucket s3://state-bucket?region=us-east-1&awssdk=v2&profile=AwsProfile: profile "AwsProfile" is configured to use SSO but is missing required configuration: sso_region, sso_start_url ``` - Try to log in with awssdk=v3 with sso-session profile, success ```bash ❯ ~/.pulumi-dev/bin/pulumi login 's3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile' Logged in to levi-framework as levi (s3://state-bucket?region=us-east-1&awssdk=v3&profile=AwsProfile) ``` Fixes #13142 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt`  - [ ] I have added tests that prove my fix is effective or that my feature works - Notes: Unsure if tests are needed to do a package update  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version  Co-authored-by: Levi Smith <levithegeek@gmail.com> Co-authored-by: Levi Smith <levi@fynx.me>

bors · 2023-08-10T20:04:01Z

Build failed:

bors-ok

Frassle · 2023-08-10T20:23:01Z

hmm ok bors seems really unhappy with this change. I'll see if anyone's got any ideas what's up, worst case we can try recreating this PR from one of our accounts and see if that behaves any better (can keep you tagged on the commit as author).

TheFynx · 2023-08-10T20:43:20Z

No worries, I'll just be happy if it gets merged in/updated one way or another.

Frassle · 2023-08-10T22:37:24Z

Looks like there may have been some github issues earlier, I'll give this another try

bors retry

bors · 2023-08-10T23:58:06Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

bors-ok

TheFynx and others added 3 commits July 28, 2023 16:13

update aws-sdk to sso session supported version

35e7745

add changelog

de4cbf9

update changelog to correct category

ee7d196

TheFynx mentioned this pull request Aug 5, 2023

AWS session-based SSO does not work with s3 backend #13142

Closed

lukehoban requested a review from justinvp August 5, 2023 21:53

lukehoban reviewed Aug 5, 2023

View reviewed changes

revert require.go back to master branch version

bbd6b34

add missing newline

c7f7cf1

Frassle approved these changes Aug 7, 2023

View reviewed changes

bors bot merged commit cb914ec into pulumi:master Aug 10, 2023
11 of 12 checks passed

midu-git mentioned this pull request Nov 23, 2023

AWS session-based SSO does not work with awskms encryption provider #14647

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update aws-sdk to sso session supported version #13619

update aws-sdk to sso session supported version #13619

TheFynx commented Jul 28, 2023

github-actions bot commented Jul 28, 2023

pulumi-bot commented Jul 28, 2023 •

edited

lukehoban commented Aug 5, 2023 •

edited by pulumi-bot

lukehoban left a comment

lukehoban Aug 5, 2023

TheFynx Aug 5, 2023

github-actions bot commented Aug 6, 2023

github-actions bot commented Aug 6, 2023

lukehoban commented Aug 6, 2023 •

edited by pulumi-bot

Frassle left a comment

bors bot commented Aug 7, 2023

TheFynx commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

Frassle commented Aug 10, 2023

TheFynx commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

update aws-sdk to sso session supported version #13619

update aws-sdk to sso session supported version #13619

Conversation

TheFynx commented Jul 28, 2023

Description

Checklist

github-actions bot commented Jul 28, 2023

pulumi-bot commented Jul 28, 2023 • edited

Changelog

[uncommitted] (2023-08-06)

Miscellaneous

lukehoban commented Aug 5, 2023 • edited by pulumi-bot

lukehoban left a comment

Choose a reason for hiding this comment

lukehoban Aug 5, 2023

Choose a reason for hiding this comment

TheFynx Aug 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 6, 2023

github-actions bot commented Aug 6, 2023

lukehoban commented Aug 6, 2023 • edited by pulumi-bot

Frassle left a comment

Choose a reason for hiding this comment

bors bot commented Aug 7, 2023

TheFynx commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

Frassle commented Aug 10, 2023

TheFynx commented Aug 10, 2023

Frassle commented Aug 10, 2023

bors bot commented Aug 10, 2023

pulumi-bot commented Jul 28, 2023 •

edited

lukehoban commented Aug 5, 2023 •

edited by pulumi-bot

lukehoban commented Aug 6, 2023 •

edited by pulumi-bot