[dotnet/program-gen] Fixes list initializer for plain lists in resource properties #13630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-08-07)Bug Fixes
|
Frassle
reviewed
Aug 7, 2023
| // if is it a plain list, then `new()` should be used because we are creating List<T> | ||
| // however if we have InputList<T> or anything else, we use `new[]` because InputList<T> can be implicitly casted | ||
| // from an array | ||
| listInitializer string |
There was a problem hiding this comment.
Bit grim this goes on the generator state? Can't we work this out, and thread it down more locally?
There was a problem hiding this comment.
Bit grim this goes on the generator state?
Yes
Can't we work this out, and thread it down more locally
Not unless we rewrite ExpressionGenerator because it not possible to know at the point of generating an expression (i.e. GenTupleConsExpxression for arrays) what context information about that expression is available 😞
Frassle
approved these changes
Aug 7, 2023
Zaid-Ajaj
force-pushed
the
zaid/fix-plain-list-initializer-csharp
branch
from
8f6de1d
to
d66a037
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
13630: [dotnet/program-gen] Fixes list initializer for plain lists in resource properties r=Zaid-Ajaj a=Zaid-Ajaj # Description Some resources, especially custom resources like those in `awsx` have properties which are _plain_ lists. This means that the generated dotnet SDK for them uses `List<T>` rather than `InputList<T>`. In case of the former, when initializing the list, we cannot use `new[]` (this works for `InputList<T>` because of an implicit conversion from arrays). Instead we have to use `new()` which initializes an instance of the `List<T>` class. This PR implements a fix such that the code generator knows when the current resource property is plain or not and subsequently emitting `new()` instead of `new[]` Fixes pulumi/pulumi-dotnet#21 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some resources, especially custom resources like those in
awsxhave properties which are plain lists. This means that the generated dotnet SDK for them usesList<T>rather thanInputList<T>. In case of the former, when initializing the list, we cannot usenew[](this works forInputList<T>because of an implicit conversion from arrays). Instead we have to usenew()which initializes an instance of theList<T>class.This PR implements a fix such that the code generator knows when the current resource property is plain or not and subsequently emitting
new()instead ofnew[]Fixes pulumi/pulumi-dotnet#21
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change