Pass provider checksums in requests and save to state #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-09-11)Features
|
Zaid-Ajaj
reviewed
Sep 11, 2023
pkg/engine/deployment.go
Outdated
| @@ -220,6 +220,9 @@ func newDeployment(ctx *Context, info *deploymentContext, opts deploymentOptions | |||
| if imp.PluginDownloadURL == "" { | |||
| imp.PluginDownloadURL = defaultProviderInfo[imp.Type.Package()].PluginDownloadURL | |||
| } | |||
| if imp.PluginChecksums != nil { | |||
There was a problem hiding this comment.
Do you mean here if imp.PluginChecksums == nil instead? Maybe also good to check that defaultProviderInfo actually has that package checksum:
checksums, ok := defaultProviderInfo[imp.Type.Package()]
if ok {
imp.PluginChecksums = checksums
}This extends the resource monitor interface with fields for plugin checksums (on top of the existing plugin version and download url fields). These fields are threaded through the engine and are persisted in resource state. The sent or saved data is then used when installing plugins to ensure that the checksums match what was recorded at the time the SDK was built. Similar to #13776 nothing is using this yet, but this lays the engine side plumbing for them.
Frassle
force-pushed
the
fraser/checksumResourceMonitor
branch
from
a0631df
to
86b375e
Compare
Zaid-Ajaj
approved these changes
Sep 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extends the resource monitor interface with fields for plugin checksums (on top of the existing plugin version and download url fields). These fields are threaded through the engine and are persisted in resource state. The sent or saved data is then used when installing plugins to ensure that the checksums match what was recorded at the time the SDK was built.
Similar to #13776 nothing is using this yet, but this lays the engine side plumbing for them.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change