Remove NodeJS and Python install scripts #13800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #13754. Fixes #13709. This removes the install scripts that we generated as part of NodeJS and Python packages. As we move to Python wheels we'll no longer have an way to run these scripts (see #13709). That would leave NodeJS as the only language which supports this feature. So for consistency and simplicity just remove it from everywhere. Users who still want to ensure plugins are installed upfront (before `up` or similar runs) can run `pulumi plugin install` to install all the current project plugins.
Changelog[uncommitted] (2023-08-27)Features
|
4 tasks
guineveresaenger
added a commit
to pulumi/pulumi-package-publisher
that referenced
this pull request
Sep 11, 2023
As per pulumi/pulumi#13800 (Pulumi v3.80.x ff), we no longer support extra runtime install scripts in the Node SDK. This pull request removes that logic during publishing. This change will go into effect when updating this Action in pulumi/ci-mgmt. Part of #12 .
This was referenced Sep 12, 2023
Closed
Remove scripts/install-pulumi-plugin.js and upgrade Pulumi
pulumi/pulumi-tf-provider-boilerplate#102
Closed
|
this is a breaking change to all existing bridged providers, do you have a way to communicate this to the greater community? |
omercnet
added a commit
to pulumiverse/pulumi-vercel
that referenced
this pull request
Sep 13, 2023
tmeckel
added a commit
to pulumiverse/pulumi-mssql
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13754.
Fixes #13709.
This removes the install scripts that we generated as part of NodeJS and Python packages. As we move to Python wheels we'll no longer have an way to run these scripts (see #13709). That would leave NodeJS as the only language which supports this feature.
So for consistency and simplicity just remove it from everywhere.
Users who still want to ensure plugins are installed upfront (before
upor similar runs) can runpulumi plugin installto install all the current project plugins.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change