-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kp/adds root pulumi ai command #13808
Conversation
Changelog[uncommitted] (2023-08-30)Features
|
65819fc
to
073993b
Compare
Addresses usage feedback and simplifies command
Expands help text for ai web
0c921aa
to
e093b15
Compare
@kpitzen a PR description, related issues, and other information would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about subcommand vs. prompt. LGTM otherwise.
}, | ||
), | ||
} | ||
cmd.AddCommand(newAIWebCommand()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still planning to rework this into a flag rather than subcommand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so for this specific command, no. I wanted to keep the interface here as simple as possible, and making pulumi ai
behave entirely differently between its future state (pprint/tui) and when --web --prompt 'some-ai-prompt'
are provided feels... not ideal from a UX perspective. I'd rather we separate its interface from the above pulumi ai
command. The other commands, like in org search
are purely a boolean flag which doesn't modify the underlying interface so simply passing --web
makes sense there.
Description
This PR is intended to add the beginnings of a set of
pulumi ai
commands to the Pulumi CLI. The first implementation is relatively straightforward - we want to be able to open the Pulumi AI app from the CLI while providing a simple set of operations for users - pre-filling the AI prompt, and optionally not running that prompt when the page is opened. The CLI should open the appropriate URL in the user's default browser, and the app should take over from there.This was implemented as a subcommand for
pulumi ai
as we intend to add more features both as siblings and at the parentpulumi ai
command in the future, as this current functionality does not represent the "final default" experience we'd like users to have when runningpulumi ai
.Fixes https://github.com/pulumi/pulumi.ai/issues/126
Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change