Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add args to state conversions #13862

Merged
merged 1 commit into from Sep 1, 2023
Merged

Add args to state conversions #13862

merged 1 commit into from Sep 1, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Sep 1, 2023 •
edited

Description

When importing from other ecosystems we need someway in import for the user to tell the converter plugin what to import.

Simply forwarding on the args pass to import looks to be the simplest option to enable this.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Sep 1, 2023 •
edited

Changelog

[uncommitted] (2023-09-01)

Features

  • [cli] Pass args from import to state converters.
    #13862

@Frassle Frassle requested a review from a team September 1, 2023 10:47
dixler
dixler approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frassle Frassle added this pull request to the merge queue Sep 1, 2023
Merged via the queue into master with commit 981be6c Sep 1, 2023
45 checks passed
@Frassle Frassle deleted the fraser/stateArgs branch September 1, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixler dixler dixler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frassle @pulumi-bot @dixler