[org search] Adds both the display of and the ability to open search results URLs

[kpitzen]

Description

Displays to users a copyable URL to view org search results in Pulumi Cloud as well as a --web flag to automatically open those results for them.

Fixes https://github.com/pulumi/pulumi.ai/issues/207

Checklist

• I have run make tidy to update any new dependencies
• I have run make lint to verify my code passes the lint check
  • I have formatted my code using gofumpt

• I have added tests that prove my fix is effective or that my feature works

• I have run make changelog and committed the changelog/pending/<file> documenting my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

[pulumi-bot]

Changelog

[uncommitted] (2023-09-11)

Features

• [cli/config] Adheres to default org for org search when one is set
  #13879

• [cli/display] Displays search URL when results table is rendered
  #13879

• [cli/display] Displays total and displayed resource counts for org search
  #13879

[Frassle]

Should this not take the client address into account for self-hosted customers?

[kpitzen]

It should! I was actually unaware we had that information available here. Let me do some digging and plumb that in.

[kpitzen]

The only place I could see this elsewhere was as passed as a CLI argument to --client. Is there another place this information is available? (Backend has the URL of the API we're interacting with, but this URL redirects to the front-end).

[Frassle]

Ah yeh I don't think we record the frontend, and doing that nicely probably requires service to give a new endpoint for us to call (because we only get the api url from the user when logging in).
Can you just add a TODO to that effect here.

[kpitzen]

Based on @justinvp 's feedback below, it seems like backend's CloudConsoleURL method will do essentially exactly what we want here. Unless you believe that's incorrect, I'll go down that path for now.

[justinvp]

LGTM otherwise

[justinvp]

I would not accept this as a flag...

We have a way to convert an API URL to Console URL, which is used when running a pulumi up (or other operation) to show a permalink to the update in Pulumi Cloud. I would think we'd want to use the same approach here:

pulumi/pkg/backend/httpstate/backend.go

Lines 1166 to 1173 in 929fb56

	// getPermalink returns a link to the update in the Pulumi Console.
	func (b *cloudBackend) getPermalink(update client.UpdateIdentifier, version int, preview bool) string {
	base := b.cloudConsoleStackPath(update.StackIdentifier)
	if !preview {
	return b.CloudConsoleURL(base, "updates", strconv.Itoa(version))
	}
	return b.CloudConsoleURL(base, "previews", update.UpdateID)
	}

pulumi/pkg/backend/httpstate/backend.go

Lines 716 to 720 in 929fb56

	// CloudConsoleURL returns a link to the cloud console with the given path elements. If a console link cannot be
	// created, we return the empty string instead (this can happen if the endpoint isn't a recognized pattern).
	func (b *cloudBackend) CloudConsoleURL(paths ...string) string {
	return cloudConsoleURL(b.CloudURL(), paths...)
	}

pulumi/pkg/backend/httpstate/console.go

Lines 39 to 69 in 929fb56

	// cloudConsoleURL returns a URL to the Pulumi Cloud Console, rooted at cloudURL. If there is
	// an error, returns "".
	func cloudConsoleURL(cloudURL string, paths ...string) string {
	u, err := url.Parse(cloudURL)
	if err != nil {
	return ""
	}
	switch {
	case os.Getenv(ConsoleDomainEnvVar) != "":
	// Honor a PULUMI_CONSOLE_DOMAIN environment variable to override the
	// default behavior. Since we identify a backend by a single URI, we
	// cannot know what the Pulumi Console is hosted at...
	u.Host = os.Getenv(ConsoleDomainEnvVar)
	case strings.HasPrefix(u.Host, defaultAPIDomainPrefix):
	// ... but if the cloudURL (API domain) is "api.", then we assume the
	// console is hosted at "app.".
	u.Host = defaultConsoleDomainPrefix + u.Host[len(defaultAPIDomainPrefix):]
	case u.Host == "localhost:8080":
	// ... or when running locally, on port 3000.
	u.Host = "localhost:3000"
	default:
	// We couldn't figure out how to convert the api hostname into a console hostname.
	// We return "" so that the caller can know to omit the URL rather than just
	// return an incorrect one.
	return ""
	}
	u.Path = path.Join(paths...)
	return u.String()
	}

[Frassle]

Ah forgot we had all this. Still would be nice to have an endpoint we could hit to be sure we've got the right url rather than the guesses in here. Something to ask service about.

[kpitzen]

Ah this makes much more sense. I was going off the original feedback re: client address which only appears once as a flag:

pulumi/pkg/cmd/pulumi/util.go

Line 517 in b8c94ed

func readProjectForUpdate(clientAddress string) (*workspace.Project, string, error) {

This makes significantly more sense to me. Thanks!