[codegen/python] fix deprecation warning on default values #13890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixler
changed the title
Changelog[uncommitted] (2023-09-12)Bug Fixes
|
dixler
force-pushed
the
dixler/12546/deprecated-2
branch
from
64e4d26
to
93a3a23
Compare
Frassle
requested changes
Sep 8, 2023
Frassle
reviewed
Sep 11, 2023
Comment on lines
38
to
43
| """ | ||
| new_resource mocks resource construction calls. This function should return the physical identifier and the output properties | ||
| for the resource being constructed. | ||
|
|
||
| :param MockResourceArgs args. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| new_resource mocks resource construction calls. This function should return the physical identifier and the output properties | |
| for the resource being constructed. | |
| :param MockResourceArgs args. | |
| """ |
No need for doc comments about the abstract method in test code.
| @pulumi.runtime.test | ||
| def test_func_with_default_value(my_mocks): | ||
| with patch("warnings.warn") as mock_warn: | ||
| pulumi_plant.tree.v1.RubberTree("my-tree", pulumi_plant.tree.v1.RubberTreeArgs()) |
There was a problem hiding this comment.
Wasn't totally obvious what this was testing to start, I would add a doc comment to this method saying what we're doing "constructing a resource with deprecated but default values and checking the default values don't trigger a deprecation warning"
dixler
force-pushed
the
dixler/12546/deprecated-2
branch
from
18463bf
to
f2df766
Compare
Frassle
approved these changes
Sep 12, 2023
Removes Resource constructor deprecation checks in favor of deprecation checks in the ResourceArgs constructor. The Resource constructor would always see the default value as set and would trigger deprecation warnings if they exist. Fixes #12546
dixler
force-pushed
the
dixler/12546/deprecated-2
branch
from
f2df766
to
0244db0
Compare
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Resource constructor deprecation checks in favor of deprecation checks in the ResourceArgs constructor.
Checks in the ResourceArgs constructor which will be changed to
ResourceArgs.__configure__in #13825 and compatible with dicts and objects that implement__getitem____setitem__.Merge #13825 after and update
__internal_init__logic to use theResourceArgs.__configure__Fixes #12546
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change