[policy/new] make pulumi policy new <template-name> runnable in non-interactive mode
#13902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-09-09)Bug Fixes
|
Fixes #13901 `pulumi policy new <template-name>` would fail requiring a `--yes` argument that did not exist when being run non-interactively. This changes `pulumi policy new <template-name>` to not require `--yes` when a template-name is provided.
dixler
force-pushed
the
dixler/13901/pulumi-policy-new-noninteractive
branch
from
21cd301
to
7cd3fda
Compare
dixler
changed the title
pulumi policy new <template-name> runnable in non-interactive modepulumi policy new <template-name> runnable in non-interactive mode
Frassle
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
justinvp
reviewed
Sep 8, 2023
tests/remote_test.go
Outdated
| @@ -154,3 +154,10 @@ func TestRemoteLifecycle(t *testing.T) { | |||
|
|
|||
| e.RunCommand("pulumi", "stack", "rm", "--stack", fullyQualifiedStack, "--yes") | |||
| } | |||
|
|
|||
| func TestPolicyNewNonInteractive(t *testing.T) { | |||
There was a problem hiding this comment.
Nit: Seems a little odd to put this test in this file. Why not a new tests/policy_new_test.go or tests/policy_test.go file?
There was a problem hiding this comment.
Oh I didn't notice this was with the remote tests, that's a good point. Make a new file.
There was a problem hiding this comment.
I went ahead and pushed a commit that moves it to a new file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13901
pulumi policy new <template-name>would fail requiring a--yesargument that did not exist when being run non-interactively.This changes
pulumi policy new <template-name>to not require--yeswhen a template-name is provided.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change