Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulumi state edit] handle multi-part EDITOR variables (i.e. emacs -nw) #13922

Merged
merged 1 commit into from Sep 12, 2023

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Sep 11, 2023

Description

pulumi state edit now properly handles multi-part EDITOR variables (i.e. emacs -nw).

Fixes #13850

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Sep 11, 2023

Changelog

[uncommitted] (2023-09-11)

Bug Fixes

  • [cli/state] pulumi state edit now handles multi-part EDITOR env vars (i.e. emacs -nw).
    #13922

@dixler dixler marked this pull request as ready for review September 11, 2023 20:05
@dixler dixler requested a review from a team September 11, 2023 20:05
pkg/cmd/pulumi/state_edit.go Outdated Show resolved Hide resolved
pkg/cmd/pulumi/state_edit_test.go Outdated Show resolved Hide resolved
@dixler dixler requested review from Zaid-Ajaj and a team and removed request for Zaid-Ajaj September 11, 2023 20:50
@dixler dixler added this pull request to the merge queue Sep 12, 2023
Merged via the queue into master with commit cbf3cd1 Sep 12, 2023
46 checks passed
@dixler dixler deleted the dixler/13850/shlex-edit branch September 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulumi state edit doesn't work with multi-part
3 participants