Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install converter plugins in 'import' as well as 'convert' #14048

Merged
merged 1 commit into from Sep 26, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Sep 26, 2023

Description

When using --from in convert it would auto install the converter, but didn't in import. This aligns them.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Sep 26, 2023

Changelog

[uncommitted] (2023-09-26)

Bug Fixes

  • [cli/import] import --from=plugin will now try to auto-install the plugin if missing.
    #14048

@Frassle Frassle force-pushed the fraser/autoInstallImportConvert branch from 1776f27 to 982c2a6 Compare September 26, 2023 09:07
@Frassle Frassle marked this pull request as ready for review September 26, 2023 09:07
@Frassle Frassle added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@Frassle Frassle added this pull request to the merge queue Sep 26, 2023
Merged via the queue into master with commit 8d3a8cd Sep 26, 2023
44 checks passed
@Frassle Frassle deleted the fraser/autoInstallImportConvert branch September 26, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants