SameSteps can fail #14076
Merged
SameSteps can fail #14076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-10-04)Bug Fixes
|
Frassle
force-pushed
the
fraser/sameStepFail
branch
from
11e04c1
to
ef55f0c
Compare
Frassle
force-pushed
the
fraser/sameStepFail
branch
from
ef55f0c
to
596f815
Compare
Zaid-Ajaj
approved these changes
Oct 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
### Features - [engine] Old inputs are sent to provider Delete functions, as well as the old outputs. [#14051](#14051) ### Bug Fixes - [engine] Fix a panic in the engine when same steps failed due to provider errors. [#14076](#14076) - [engine] Engine is now more efficent about starting up provider processes, generally saving at least one process startup per deployment. [#14127](#14127) - [programgen] Fixes panic when binding the signature of output-versioned invokes without input arguments [#14234](#14234) - [sdkgen/python] Python SDK generation _configure now correctly handles original property names for resource arguments (i.e. user provides `propName` instead of `prop_name`). [#14235](#14235)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
### Features - [engine] Old inputs are sent to provider Delete functions, as well as the old outputs. [#14051](#14051) ### Bug Fixes - [engine] Fix a panic in the engine when same steps failed due to provider errors. [#14076](#14076) - [engine] Engine is now more efficent about starting up provider processes, generally saving at least one process startup per deployment. [#14127](#14127) - [programgen] Fixes panic when binding the signature of output-versioned invokes without input arguments [#14234](#14234) - [sdkgen/python] Python SDK generation _configure now correctly handles original property names for resource arguments (i.e. user provides `propName` instead of `prop_name`). [#14235](#14235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix the panic in #13923, but will probably just cause a new error to be raised for that use case.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change