Mark diff as an input diff when auto-diffing in the step generator #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-10-18)Bug Fixes
|
Fixes #14040 When a provider returns `DiffUnknown` the step generator calculates a simple diff based on the old and new inputs. We were not correctly marking that this is an input diff, and so when reconstructing objects from the detailed diff later in `TranslateDetailedDiff` we we're looking at the old output properties rather than the old input properties.
Frassle
force-pushed
the
fraser/inputDiff
branch
from
b5031cd
to
dddec7b
Compare
justinvp
approved these changes
Oct 18, 2023
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
### Features - [auto/nodejs] Add support for the path option for config operations [#14305](#14305) - [engine] Converters can return diagnostics from `ConvertState`. [#14135](#14135) ### Bug Fixes - [cli] Tightened the parser for property paths to be less prone to typos [#14257](#14257) - [engine] Fix handling of explicit providers and --target-dependents. [#14238](#14238) - [engine] Fix automatic diffs comparing against output instead of input properties. [#14256](#14256) - [sdkgen/dotnet] Fix codegen with nested modules. [#14297](#14297) - [programgen/go] Fix codegen to correctly output pulumi.Array instead of pulumi.AnyArray [#14299](#14299) - [cli/new] `pulumi new` now allows users to bypass existing project name checks. [#14081](#14081) - [sdk/nodejs] Nodejs now supports unknown resource IDs. [#14137](#14137) - [sdkgen/python] Fix `_configure` failing due to required args mismatch. [#14281](#14281) ### Miscellaneous - [cli] Pull in fixes from esc v0.5.6 [#14284](#14284) - [protobuf] Add a config as property map field to RunRequest and pass that to the SDK [#14273](#14273) - [sdk/python] updates grpcio dependency [#14259](#14259)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
### Features - [auto/nodejs] Add support for the path option for config operations [#14305](#14305) - [engine] Converters can return diagnostics from `ConvertState`. [#14135](#14135) ### Bug Fixes - [cli] Tightened the parser for property paths to be less prone to typos [#14257](#14257) - [engine] Fix handling of explicit providers and --target-dependents. [#14238](#14238) - [engine] Fix automatic diffs comparing against output instead of input properties. [#14256](#14256) - [sdkgen/dotnet] Fix codegen with nested modules. [#14297](#14297) - [programgen/go] Fix codegen to correctly output pulumi.Array instead of pulumi.AnyArray [#14299](#14299) - [cli/new] `pulumi new` now allows users to bypass existing project name checks. [#14081](#14081) - [sdk/nodejs] Nodejs now supports unknown resource IDs. [#14137](#14137) - [sdkgen/python] Fix `_configure` failing due to required args mismatch. [#14281](#14281) ### Miscellaneous - [cli] Pull in fixes from esc v0.5.6 [#14284](#14284) - [protobuf] Add a config as property map field to RunRequest and pass that to the SDK [#14273](#14273) - [sdk/python] updates grpcio dependency [#14259](#14259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14040
When a provider returns
DiffUnknownthe step generator calculates a simple diff based on the old and new inputs.We were not correctly marking that this is an input diff, and so when reconstructing objects from the detailed diff later in
TranslateDetailedDiffwe we're looking at the old output properties rather than the old input properties.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change