Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support {NAME} in plugin download url #14435

Merged
merged 1 commit into from Oct 30, 2023
Merged

Support {NAME} in plugin download url #14435

merged 1 commit into from Oct 30, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Oct 28, 2023 •
edited

Description

Allows ${NAME} in the download url template string.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Frassle Frassle requested a review from a team October 28, 2023 08:55
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2023-10-28)

Features

  • [engine] Support {NAME} in http plugin download URLs.
    #14435

@Frassle Frassle marked this pull request as ready for review October 28, 2023 09:14
@Frassle Frassle added this pull request to the merge queue Oct 30, 2023
Merged via the queue into master with commit a605059 Oct 30, 2023
44 checks passed
@Frassle Frassle deleted the fraser/pluginNameUrl branch October 30, 2023 10:18
@justinvp justinvp mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgummerer tgummerer tgummerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frassle @pulumi-bot @tgummerer