New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow importing a parent and child resource at the same time #14461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-10-31)Features
|
Frassle
force-pushed
the
fraser/importParent
branch
2 times, most recently
from
October 31, 2023 17:01
a465df8
to
38d4a9a
Compare
Frassle
force-pushed
the
fraser/importParent
branch
from
October 31, 2023 23:12
38d4a9a
to
a7cc457
Compare
Frassle
force-pushed
the
fraser/importParent
branch
from
October 31, 2023 23:28
a7cc457
to
c8341b8
Compare
7 tasks
justinvp
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
### Features - [engine] `import` can now create empty component resource to use as the parent of other imported resources. [#14467](#14467) - [engine] `import` can now import a parent resource in the same deployment as a child resource. [#14461](#14461) - [engine] Import files no longer need parent URNs in the name table for resource being imported in the same file. - [cli/config] `config refresh` will now restore secret provider config from the last deployment. [#13900](#13900) - [cli/new] Simplifies URL parsing for pulumi new zip [#14546](#14546) ### Bug Fixes - [components/yaml] Upgrade yaml to 1.4.1 [#14542](#14542) - [engine] Ignore spurious error from Kubernetes providers DiffConfig method. [#14533](#14533)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
### Features - [engine] `import` can now create empty component resource to use as the parent of other imported resources. [#14467](#14467) - [engine] `import` can now import a parent resource in the same deployment as a child resource. [#14461](#14461) - [engine] Import files no longer need parent URNs in the name table for resource being imported in the same file. [#14524](#14524) - [cli/config] `config refresh` will now restore secret provider config from the last deployment. [#13900](#13900) - [cli/new] Simplifies URL parsing for pulumi new zip [#14546](#14546) ### Bug Fixes - [components/yaml] Upgrade yaml to 1.4.1 [#14542](#14542) - [engine] Ignore spurious error from Kubernetes providers DiffConfig method. [#14533](#14533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
pulumi import
to import one resource and then use that resource as a parent for another imported resource.Currently parents can only refer to resources that already exist in the deployment meaning if you want to do this today you have to do two imports.
Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change