Adds nested directory support to pulumi new .zip #14473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-11-01)Bug Fixes
|
kpitzen
force-pushed
the
KP/AddsDirectorySupportZIP
branch
2 times, most recently
from
e2b5888
to
37fe60a
Compare
kpitzen
force-pushed
the
KP/AddsDirectorySupportZIP
branch
from
37fe60a
to
11cd0c2
Compare
Frassle
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous ZIP implementation here only supported a flat .zip file structure - Pulumi Java projects often contain nested directories (and many templates will likely organize code in such a way that involves directories as well). This inspects each file during traversal of the ZIP archive, and creates any necessary directories it encounters along the way.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change