Fix ignoreChanges to handle secrets #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-11-15)Bug Fixes
|
Frassle
force-pushed
the
fraser/ignoreChangesSecrets
branch
from
b6c9e4a
to
1c301ea
Compare
Frassle
force-pushed
the
fraser/ignoreChangesSecrets
branch
from
1c301ea
to
de1dfd6
Compare
tgummerer
reviewed
Nov 15, 2023
Frassle
force-pushed
the
fraser/ignoreChangesSecrets
branch
from
9a4e1c8
to
4953013
Compare
tgummerer
approved these changes
Nov 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Should outputness also be handled in this way? |
|
Probably but there's also deps and unknowness that need tracking in that case so it's a bit more involved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6272.
#6272 was failing because the type checks in
PropertyPath.Resetwere too strict. We'd check if a value was an object or array to correctly traverse it, but didn't handle that it might be a "secret object" or "secret array".Pretty simple fix, we can just unwrap any outer layers of secretness at each layer as we traverse.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change