Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Consolidate CodeCov Upload #14667

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[ci] Consolidate CodeCov Upload #14667

merged 1 commit into from
Dec 4, 2023

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Nov 27, 2023

Description

Fixes #13835

Change CodeCov to only upload on completely if all jobs succeed. Consolidates CodeCov upload task in ci-run-test.yml to ci.yml.

There are extraneous commits that will be squashed before merging to retain commit 55e783c997021d9c5fae2252708ad35f62eb20c6 displaying a successful run for the reviewer.

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 27, 2023

Changelog

[uncommitted] (2023-12-04)

@dixler dixler added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 27, 2023
@dixler dixler force-pushed the dixler-13835 branch 16 times, most recently from f5ff28c to fa2f565 Compare November 30, 2023 19:46
@dixler dixler marked this pull request as ready for review November 30, 2023 19:47
@dixler dixler requested review from a team and justinvp November 30, 2023 19:47
@dixler
Copy link
Contributor Author

dixler commented Dec 1, 2023

Will rebase origin/master to make tests faster and less flaky

@dixler dixler force-pushed the dixler-13835 branch 2 times, most recently from 2c86668 to c8d6a38 Compare December 1, 2023 19:27
@dixler dixler enabled auto-merge December 1, 2023 19:38
@dixler dixler disabled auto-merge December 1, 2023 19:38
@dixler dixler enabled auto-merge December 1, 2023 19:54
@dixler dixler disabled auto-merge December 1, 2023 19:55
dixler pushed a commit that referenced this pull request Dec 1, 2023
Fixes #14716

After #14667, this workflow is no
longer necessary.
@dixler dixler added this pull request to the merge queue Dec 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2023
Fixes #14716
Reverts #13334

After #14667, this workflow is no
longer necessary.
@dixler dixler added this pull request to the merge queue Dec 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2023
@dixler
Copy link
Contributor Author

dixler commented Dec 3, 2023

macOS can't run this hash command

/Users/runner/work/_temp/c1fcb256-c95e-498b-9692-e95b749e45ac.sh: line 1: sha256sum: command not found

using git hash-object --literally --stdin and specifying to use bash due to windows.

@dixler dixler enabled auto-merge December 4, 2023 01:04
@dixler dixler added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
Fixes #13835

Consolidate CodeCov upload task in ci-run-test.yml to ci.yml.
@dixler dixler added this pull request to the merge queue Dec 4, 2023
Merged via the queue into master with commit 5d0e761 Dec 4, 2023
45 checks passed
@dixler dixler deleted the dixler-13835 branch December 4, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload all coverage data or none
3 participants