Actually save root on plugin.Context #14684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pretty sure this has been broken since forever.
Pretty sure it's only mostly worked because we nearly always run pulumi from the directory with the Pulumi.yaml file and there's a bit of code in
buildArgsForNewPlugin
that callsfilepath.Abs(root)
before passing it to the language plugins.Abs("")
will just resolve to the working directory, which as above is nearly always the one with the Pulumi.yaml file in it.Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change