Add LogicalName to import system #14745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-12-11)Features
|
Frassle
force-pushed
the
fraser/logicalName
branch
3 times, most recently
from
3001d7a
to
98d6107
Compare
Frassle
commented
Dec 6, 2023
| @@ -92,7 +146,7 @@ func buildImportFile(events <-chan engine.Event) *promise.Promise[importFile] { | |||
| var parent string | |||
| if new.Parent != "" { | |||
| // If the parent is just the root stack then skip it as we don't need to import that. | |||
| if new.Parent.Type() != resource.RootStackType { | |||
| if new.Parent.QualifiedType() != resource.RootStackType { | |||
There was a problem hiding this comment.
Substacks means this should check qualified type not just type. Missed that when adding this.
Frassle
force-pushed
the
fraser/logicalName
branch
from
98d6107
to
8896872
Compare
justinvp
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14618.
This adds a new field to the import file "logicalName", which if set is used as the logical name (https://www.pulumi.com/docs/concepts/resources/names/#logicalname) of the resource. The original "name" field is then used just for codegen purposes (i.e. the source name).
If either field is not set then the other field is used to fill it in. If neither field is set it's an error.
Further the import system no longer renames resources to try and make unique names, but it also no longer errors just because two resources of different types have the same name. The rules for uniqueness now match what's valid when writing a Pulumi program, but it is the users responsibility to make names unique and the import system will error if you try to import two resources that would end up with the same URN.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change