Don't set inputs to empty if inputs was undefined #14803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-12-11)Bug Fixes
|
tgummerer
approved these changes
Dec 11, 2023
Frassle
force-pushed
the
fraser/fixNodeProvider
branch
from
797637f
to
a8f89f0
Compare
|
Are there tests we can add here? The original PR that introduced this was also missing tests, feels like coverage for the desired state of this capability is needed.
Is there an issue tracking this? Would love to have a record of the problem that was fixed here. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Frassle
force-pushed
the
fraser/fixNodeProvider
branch
from
a8f89f0
to
5a5a8fc
Compare
Linked to #14819
In this PR, probably not in a valuable way. But I think we can do something like the conformance testing but for the provider interfaces pretty simply to cover this. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14819.
NodeJS providers started returning empty inputs rather than unknown inputs from Read.