Revert "[ci] enable coverage on merge job" #14804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-12-08)Bug Fixes
|
justinvp
approved these changes
Dec 8, 2023
dixler
force-pushed
the
revert-14727-dixler-enable-coverage
branch
from
b95bae0
to
fc6317e
Compare
Just added this take a look. |
dixler
force-pushed
the
revert-14727-dixler-enable-coverage
branch
from
fc6317e
to
4daf352
Compare
justinvp
approved these changes
Dec 8, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
Will merge this after #14804 merges.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
…erage (#14806) Fixes #14817 As a follow-up to #14804, we need to re-enable code coverage without releases being built with coverage. #14804 includes a test in the release job to catch `pulumi` being released with coverage data. Also fixes the test to check that the pulumi binary is not built with coverage. Background: Coverage was disabled on merge jobs in order to fix [#14799]. [#14716] removed nightly coverage workflows in favor of collecting coverage on merges [#14727]. The binaries built with coverage were used in the downstream prepare-release job causing a noticable bug [#14799].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14799
Reverts #14727
This PR reverts enabling coverage on the merge job.
prepare-release uses the binaries built during tests which were built with coverage.