Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appease linters. #1494

Merged
merged 1 commit into from Jun 11, 2018
Merged

Appease linters. #1494

merged 1 commit into from Jun 11, 2018

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Jun 11, 2018

  • Fix a couple self-assignment issues in the Go language support
  • Disable megacheck for fh.SetModTime, which we use for go1.9
    compat.

@pgavlin
Appease linters.
e6849a2 
- Fix a couple self-assignment issues in the Go language support
- Disable `megacheck` for `fh.SetModTime`, which we use for go1.9
  compat.
@pgavlin pgavlin requested review from joeduffy and ellismg June 11, 2018 21:33
@pgavlin pgavlin merged commit f06b50d into master Jun 11, 2018
@pgavlin pgavlin deleted the LinterAppeasement branch June 11, 2018 21:52
@joeduffy
Copy link
Member

LGTM, thank you!

mmdriley added a commit to mmdriley/pulumi that referenced this pull request Apr 5, 2023
@mmdriley
Remove outdated comments
d8e2737 
The call to `SetModTime` was removed in pulumi#11002 but the comment stayed around. The `nolint` directive had been added in pulumi#1494 to excuse the (now-removed) use of `SetModTime`.
@mmdriley mmdriley mentioned this pull request Apr 5, 2023
Merged
bors bot added a commit that referenced this pull request Apr 5, 2023
@bors @mmdriley
Merge #12603
dc2871e 
12603: Remove outdated comments r=Frassle a=mmdriley

The call to `SetModTime` was removed in #11002 but the comment stayed around. The `nolint` directive had been added in #1494 to excuse the (now-removed) use of `SetModTime`.


Co-authored-by: Matthew Riley <mdriley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellismg ellismg ellismg approved these changes

@joeduffy joeduffy Awaiting requested review from joeduffy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgavlin @joeduffy @ellismg