Upgrade output values in source_eval #15362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-02-06)Features
|
Frassle
force-pushed
the
fraser/outputDowngrade
branch
9 times, most recently
from
e33d7ff
to
77fc606
Compare
Frassle
changed the title
Frassle
force-pushed
the
fraser/outputDowngrade
branch
from
77fc606
to
da662c5
Compare
Frassle
force-pushed
the
fraser/outputDowngrade
branch
2 times, most recently
from
c054806
to
cbb5a53
Compare
Frassle
force-pushed
the
fraser/outputDowngrade
branch
from
cbb5a53
to
1b6b197
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
Current draft release notes: ### Features - [auto/go] Adds support for `--refresh` to Stack.Up(), Stack.Preview() and Stack.Destroy() via go automation api [#15350](#15350) - [cli] Adds a `preview-only` flag to `pulumi refresh`. [#15330](#15330) - [cli] Adds `preview-only` flag for `pulumi destroy` and `pulumi import` [#15336](#15336) - [engine] Translate all Computed and Secret values to OutputValues for Construct and Call methods. [#15362](#15362) - [cli/display] Add --suppress-progress option to not print dots [#14690](#14690) - [sdk/go] Add `UpgradeToOutputValues` to `MarshalOptions`. [#15349](#15349) - [cli/plugin] Add experimental `plugin run` command for running plugin binaries directly. [#12613](#12613) - [sdkgen/python] Update the default minimum required version of Python to 3.8 or greater for generated provider SDKs. [#15368](#15368) ### Bug Fixes - [backend/diy] Fix an issue where state stored on a mounted device would result in errors [#15375](#15375) - [cli/state] Fix a panic when trying to delete a provider from the state that's still referenced. [#15322](#15322) - [cli/state] Fix a nil reference panic in the `state edit` command. [#15354](#15354) ### Miscellaneous - [docs] Add kubernetes as a supported pulumi convert language [#15359](#15359) - [sdk/python] Require Python 3.8 or greater. [#15363](#15363) - [sdk/python] Upgrade grpcio to 1.60.1 [#15366](#15366)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Features - [auto/go] Adds support for `--refresh` to Stack.Up(), Stack.Preview() and Stack.Destroy() via go automation api [#15350](#15350) - [cli] Adds a `preview-only` flag to `pulumi refresh`. [#15330](#15330) - [cli] Adds `preview-only` flag for `pulumi destroy` and `pulumi import` [#15336](#15336) - [engine] Translate all Computed and Secret values to OutputValues for Construct and Call methods. [#15362](#15362) - [cli/display] Add --suppress-progress option to not print dots [#14690](#14690) - [sdk/go] Add `UpgradeToOutputValues` to `MarshalOptions`. [#15349](#15349) - [cli/plugin] Add experimental `plugin run` command for running plugin binaries directly. [#12613](#12613) - [sdkgen/python] Update the default minimum required version of Python to 3.8 or greater for generated provider SDKs. [#15368](#15368) ### Bug Fixes - [backend/diy] Fix an issue where state stored on a mounted device would result in errors [#15375](#15375) - [cli/state] Fix a panic when trying to delete a provider from the state that's still referenced. [#15322](#15322) - [cli/state] Fix a nil reference panic in the `state edit` command. [#15354](#15354) ### Miscellaneous - [docs] Add kubernetes as a supported pulumi convert language [#15359](#15359) - [sdk/python] Require Python 3.8 or greater. [#15363](#15363) - [sdk/python] Upgrade grpcio to 1.60.1 [#15366](#15366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stage 1 of updating how we deal with OutputValues in source_eval for transforms.
This makes two changes that should result in basically a no-op for standard resources, but update all Computed/Secret values to OutputValues for Call and Construct.
This is a no-op for standard resources because previously we set "KeepOutputs" to false when we unmarshalled them. That replaced all OutputValues with Computed/Secret. Now we do "UpdgradeOutputs" at the start of source_eval but then call "DowngradeOutputs" before passing the properties on to the rest of the system. So this is a complete no-op.
But for Call/Construct we used to use "KeepOutputs" but now we do "UpgradeOutputs". So values that previously got sent as Computed/Secret will now get sent as OutputValue. This should be fine, all users of Construct/Call already had to handle OutputValue on their interface, so this just means a few more cases of seeing those values.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change