Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update engine test to use GRPC and fix issues #15405

Merged
merged 1 commit into from Feb 8, 2024
Merged

Update engine test to use GRPC and fix issues #15405

merged 1 commit into from Feb 8, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Feb 8, 2024 •
edited

Description

So it turned out that the server code for providers was set up to never return output values. I don't think any actual providers used this code but it meant the tests running in GRPC mode started to fail.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Frassle Frassle marked this pull request as ready for review February 8, 2024 15:02
@Frassle Frassle requested a review from a team February 8, 2024 15:03
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2024-02-08)

Bug Fixes

  • [components/go] Component providers now correctly return output values to the engine.
    #15405

Frassle
Frassle commented Feb 8, 2024
View reviewed changes
pkg/engine/lifecycletest/pulumi_test.go
@@ -4875,118 +4875,129 @@ func TestConstructCallSecretsUnknowns(t *testing.T) {
func TestConstructCallReturnDependencies(t *testing.T) {
t.Parallel()

loaders := []*deploytest.ProviderLoader{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't changed, just indention by one level

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hiding whitespace changes in this PR made it so much easier to review!

tgummerer
tgummerer approved these changes Feb 8, 2024
View reviewed changes
pkg/engine/lifecycletest/pulumi_test.go
@@ -4875,118 +4875,129 @@ func TestConstructCallSecretsUnknowns(t *testing.T) {
func TestConstructCallReturnDependencies(t *testing.T) {
t.Parallel()

loaders := []*deploytest.ProviderLoader{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hiding whitespace changes in this PR made it so much easier to review!

@Frassle Frassle force-pushed the fraser/fixOutputValuesConstruct branch from 040875b to c6733f3 Compare February 8, 2024 15:47
@Frassle Frassle added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit ff6404a Feb 8, 2024
46 checks passed
@Frassle Frassle deleted the fraser/fixOutputValuesConstruct branch February 8, 2024 17:15
@justinvp justinvp mentioned this pull request Feb 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 15, 2024
@justinvp
Prepare for v3.106.0 release (#15427)
0211ab4 
### Features

- [components] Component providers can return output values in their
response to the engine.

- [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for
resources and local variables
  [#15419](#15419)


### Bug Fixes

- [engine] Engine no longer assumes program dependencies are specified
as semantic versions.
  [#15409](#15409)

- [components/go] Component providers now correctly return output values
to the engine.
  [#15405](#15405)


### Miscellaneous

- [protobuf] Split CallRequest into ResourceCallRequest for the
ResourceMonitor service.
  [#15404](#15404)

- [backend/diy] Add a warning that non-project mode will be deprecated
at some point.
  [#15411](#15411)
@justinvp justinvp mentioned this pull request Feb 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 16, 2024
@justinvp
Freeze v3.106.0 (#15437)
62ba944 
### Features

- [components] Component providers can return output values in their
response to the engine.
  [#15408](#15408)

- [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for
resources and local variables
  [#15419](#15419)

- [sdk/{nodejs,python}] Publish dev versions of the nodejs and python
SDKs


### Bug Fixes

- [cli] Fix `pulumi destroy` to fill in stack config with the secret
config from state, not fresh secret config.
  [#15432](#15432)

- [engine] Engine no longer assumes program dependencies are specified
as semantic versions.
  [#15409](#15409)

- [components/go] Component providers now correctly return output values
to the engine.
  [#15405](#15405)


### Miscellaneous

- [protobuf] Split CallRequest into ResourceCallRequest for the
ResourceMonitor service.
  [#15404](#15404)

- [backend/diy] Add a warning that non-project mode will be deprecated
at some point.
  [#15411](#15411)
@EronWright EronWright mentioned this pull request Feb 22, 2024
Closed
EronWright added a commit to pulumi/pulumi-random that referenced this pull request Feb 27, 2024
@EronWright
Fix for replay test (pulumi/pulumi#15405)
adeebb5
EronWright added a commit to pulumi/pulumi-random that referenced this pull request Feb 27, 2024
@EronWright
Fix for replay test (pulumi/pulumi#15405)
fe0f0ad
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Mar 3, 2024
@lumiere-bot
fix(deps): update @pulumi/random to 4.16.0 (#4291)
933ed2c 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/random](https://pulumi.io)
([source](https://togithub.com/pulumi/pulumi-random)) | dependencies |
minor | [`4.15.1` ->
`4.16.0`](https://renovatebot.com/diffs/npm/@pulumi%2frandom/4.15.1/4.16.0)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pulumi/pulumi-random (@&#8203;pulumi/random)</summary>

###
[`v4.16.0`](https://togithub.com/pulumi/pulumi-random/releases/tag/v4.16.0)

[Compare
Source](https://togithub.com/pulumi/pulumi-random/compare/v4.15.1...v4.16.0)

#### Changelog

- [`fe0f0ad`](https://togithub.com/pulumi/pulumi-random/commit/fe0f0ad)
Fix for replay test
([pulumi/pulumi#15405](https://togithub.com/pulumi/pulumi/issues/15405))
- [`88f31e6`](https://togithub.com/pulumi/pulumi-random/commit/88f31e6)
Update GitHub Actions workflows.
([#&#8203;622](https://togithub.com/pulumi/pulumi-random/issues/622))
- [`3852245`](https://togithub.com/pulumi/pulumi-random/commit/3852245)
Update GitHub Actions workflows.
([#&#8203;669](https://togithub.com/pulumi/pulumi-random/issues/669))
- [`c81e055`](https://togithub.com/pulumi/pulumi-random/commit/c81e055)
Update GitHub Actions workflows.
([#&#8203;673](https://togithub.com/pulumi/pulumi-random/issues/673))
- [`ff992a5`](https://togithub.com/pulumi/pulumi-random/commit/ff992a5)
Update GitHub Actions workflows.
([#&#8203;685](https://togithub.com/pulumi/pulumi-random/issues/685))
- [`f080470`](https://togithub.com/pulumi/pulumi-random/commit/f080470)
Update GitHub Actions workflows.
([#&#8203;695](https://togithub.com/pulumi/pulumi-random/issues/695))
- [`308c3cb`](https://togithub.com/pulumi/pulumi-random/commit/308c3cb)
Update GitHub Actions workflows.
([#&#8203;699](https://togithub.com/pulumi/pulumi-random/issues/699))
- [`11ea5d2`](https://togithub.com/pulumi/pulumi-random/commit/11ea5d2)
Update GitHub Actions workflows.
([#&#8203;701](https://togithub.com/pulumi/pulumi-random/issues/701))
- [`a930a8e`](https://togithub.com/pulumi/pulumi-random/commit/a930a8e)
Update GitHub Actions workflows.
([#&#8203;702](https://togithub.com/pulumi/pulumi-random/issues/702))
- [`985d7f3`](https://togithub.com/pulumi/pulumi-random/commit/985d7f3)
Update GitHub Actions workflows.
([#&#8203;705](https://togithub.com/pulumi/pulumi-random/issues/705))
- [`fa27d9b`](https://togithub.com/pulumi/pulumi-random/commit/fa27d9b)
Update GitHub Actions workflows.
([#&#8203;714](https://togithub.com/pulumi/pulumi-random/issues/714))
- [`71a4e36`](https://togithub.com/pulumi/pulumi-random/commit/71a4e36)
Update GitHub Actions workflows.
([#&#8203;721](https://togithub.com/pulumi/pulumi-random/issues/721))
- [`ece76ae`](https://togithub.com/pulumi/pulumi-random/commit/ece76ae)
Update GitHub Actions workflows.
([#&#8203;723](https://togithub.com/pulumi/pulumi-random/issues/723))
- [`476a4d8`](https://togithub.com/pulumi/pulumi-random/commit/476a4d8)
Update GitHub Actions workflows.
([#&#8203;726](https://togithub.com/pulumi/pulumi-random/issues/726))
- [`a092b5e`](https://togithub.com/pulumi/pulumi-random/commit/a092b5e)
Update bridge to 3.76.0
([#&#8203;724](https://togithub.com/pulumi/pulumi-random/issues/724))
- [`d98e05e`](https://togithub.com/pulumi/pulumi-random/commit/d98e05e)
Upgrade pulumi-terraform-bridge to v3.72.0
([#&#8203;643](https://togithub.com/pulumi/pulumi-random/issues/643))
- [`90b1432`](https://togithub.com/pulumi/pulumi-random/commit/90b1432)
Upgrade pulumi-terraform-bridge to v3.73.0
([#&#8203;672](https://togithub.com/pulumi/pulumi-random/issues/672))
- [`8d6a42f`](https://togithub.com/pulumi/pulumi-random/commit/8d6a42f)
Upgrade pulumi-terraform-bridge to v3.74.0
([#&#8203;692](https://togithub.com/pulumi/pulumi-random/issues/692))
- [`1e29872`](https://togithub.com/pulumi/pulumi-random/commit/1e29872)
go.mod
- [`0f93aa7`](https://togithub.com/pulumi/pulumi-random/commit/0f93aa7)
go.mod (examples)
- [`f01461f`](https://togithub.com/pulumi/pulumi-random/commit/f01461f)
make build_sdks
- [`eef7ddf`](https://togithub.com/pulumi/pulumi-random/commit/eef7ddf)
tfgen

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTkuNCIsInVwZGF0ZWRJblZlciI6IjM3LjIxOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgummerer tgummerer tgummerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frassle @pulumi-bot @tgummerer