Improve misleading pulumi new summary message
#1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention running `cd` (if needed) before `pulumi update`.
lukehoban
approved these changes
Jun 25, 2018
| cd = fmt.Sprintf("\"%s\"", cd) | ||
| } | ||
|
|
||
| fmt.Printf("Run 'cd %s' then 'pulumi update'.\n", cd) |
There was a problem hiding this comment.
On purpose that there is a trailing newline here but not in the other branch?
There was a problem hiding this comment.
The else uses Println whereas Printf with explicit \n is used here. (I really wish go had a built-in Printlnf).
There was a problem hiding this comment.
Ahh - yeah - totally missed that.
I just completely avoid Println myself to avoid this confusion 😄.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention running
cd(if needed) beforepulumi update.Fixes #1508