Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[program-gen/go,dotnet] Fixes emited code for object expressions assigned to properties of type Any #15770

Merged
merged 1 commit into from Mar 24, 2024
Merged

[program-gen/go,dotnet] Fixes emited code for object expressions assigned to properties of type Any #15770

merged 1 commit into from Mar 24, 2024

Conversation

Zaid-Ajaj
Copy link
Contributor

Description

Fixes #15769 by specifically handling object expressions that are annotated as Any and emitting the correct code.

  • In case of Go, expression X is emitted as pulumi.Any(X) where the type name here is map[string]interface{}.
  • In case of C#, we generate Dictionary<string, object?> expressions (similar to what we do inside toJSON calls)
  • Updates the test aws-native schema from 0.13.0 to 0.99.0

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Zaid-Ajaj Zaid-Ajaj requested a review from a team as a code owner March 23, 2024 19:59
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Mar 23, 2024 •
edited

Changelog

[uncommitted] (2024-03-23)

Bug Fixes

  • [programgen/{dotnet,go}] Fixes emitted code for object expressions assigned to properties of type Any
    #15770

This was referenced Mar 23, 2024
Closed
Closed
Closed
Closed
@pulumi-bot pulumi-bot mentioned this pull request Mar 23, 2024
Closed
@Zaid-Ajaj Zaid-Ajaj added this pull request to the merge queue Mar 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2024
@Zaid-Ajaj Zaid-Ajaj force-pushed the zaid/fix-mapping-objects-onto-any-type branch from 4ba7f44 to 4c17acb Compare March 23, 2024 23:44
This was referenced Mar 23, 2024
Closed
Closed
@Zaid-Ajaj Zaid-Ajaj added this pull request to the merge queue Mar 24, 2024
This was referenced Mar 24, 2024
Closed
Closed
Merged via the queue into master with commit 7627d80 Mar 24, 2024
58 of 59 checks passed
@Zaid-Ajaj Zaid-Ajaj deleted the zaid/fix-mapping-objects-onto-any-type branch March 24, 2024 00:49
@pulumi-bot pulumi-bot mentioned this pull request Mar 24, 2024
Closed
@t0yv0 t0yv0 mentioned this pull request Mar 25, 2024
Closed
@justinvp justinvp mentioned this pull request Mar 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 27, 2024
@justinvp
Prepare for v3.112.0 release (#15794)
13ef42b 
Tentative changelog:

### Features

- [docs] Implement constructor syntax examples for every resource in
typescript, python, csharp and go
  [#15624](#15624)

- [engine] Send output values with property dependency information to
transform functions
  [#15637](#15637)

- [engine] Add a --continue-on-error flag to pulumi destroy
  [#15727](#15727)

- [sdk/go] Make `property.Map` keyed by `string` not `MapKey`
  [#15767](#15767)

- [sdk/python] Improve the error message when depends_on is passed
objects of the wrong type
  [#15737](#15737)


### Bug Fixes

- [auto/{go,nodejs,python}] Make sure to read complete lines before
trying to deserialize them as engine events
  [#15778](#15778)

- [cli/plugin] Fix installing local language plugins on Windows
  [#15715](#15715)

- [engine] Don't delete stack outputs on failed deployments
  [#15754](#15754)

- [engine] Fix a panic when updating provider version in a run using
--target
  [#15716](#15716)

- [engine] Handle that Assets & Archives can be returned from providers
without content.
  [#15736](#15736)

- [engine] Fix the engine trying to delete a protected resource caught
in a replace chain
  [#15776](#15776)

- [sdkgen/docs] Add missing newline for `Coming soon!`
  [#15783](#15783)

- [programgen/dotnet] Fix generated code for a list of resources used in
resource option DependsOn
  [#15773](#15773)

- [programgen/{dotnet,go}] Fixes emitted code for object expressions
assigned to properties of type Any
  [#15770](#15770)

- [sdk/go] Fix lookup of plugin and program dependencies when using Go
workspaces
  [#15743](#15743)

- [sdk/nodejs] Export automation.tag.TagMap type
  [#15774](#15774)

- [sdk/python] Wait only for pending outputs in the Python SDK, not all
pending asyncio tasks
  [#15744](#15744)


### Miscellaneous

- [sdk/nodejs] Reorganize function serialization tests
  [#15753](#15753)

- [sdk/nodejs] Move mockpackage tests to closure integration tests
  [#15757](#15757)
@justinvp justinvp mentioned this pull request Mar 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2024
@justinvp
Freeze v3.112.0 (#15799)
89cd536 
Tentative changelog:

### Features

- [docs] Implement constructor syntax examples for every resource in
typescript, python, csharp and go
  [#15624](#15624)

- [docs] Implement YAML constructor syntax examples in the docs
  [#15791](#15791)

- [engine] Send output values with property dependency information to
transform functions
  [#15637](#15637)

- [engine] Add a --continue-on-error flag to pulumi destroy
  [#15727](#15727)

- [sdk/go] Make `property.Map` keyed by `string` not `MapKey`
  [#15767](#15767)

- [sdk/nodejs] Make function serialization work with typescript 4 and 5
  [#15761](#15761)

- [sdk/python] Improve the error message when depends_on is passed
objects of the wrong type
  [#15737](#15737)


### Bug Fixes

- [auto/{go,nodejs,python}] Make sure to read complete lines before
trying to deserialize them as engine events
  [#15778](#15778)

- [cli/plugin] Fix installing local language plugins on Windows
  [#15715](#15715)

- [engine] Don't delete stack outputs on failed deployments
  [#15754](#15754)

- [engine] Fix a panic when updating provider version in a run using
--target
  [#15716](#15716)

- [engine] Handle that Assets & Archives can be returned from providers
without content.
  [#15736](#15736)

- [engine] Fix the engine trying to delete a protected resource caught
in a replace chain
  [#15776](#15776)

- [sdkgen/docs] Add missing newline for `Coming soon!`
  [#15783](#15783)

- [programgen/dotnet] Fix generated code for a list of resources used in
resource option DependsOn
  [#15773](#15773)

- [programgen/{dotnet,go}] Fixes emitted code for object expressions
assigned to properties of type Any
  [#15770](#15770)

- [sdk/go] Fix lookup of plugin and program dependencies when using Go
workspaces
  [#15743](#15743)

- [sdk/nodejs] Export automation.tag.TagMap type
  [#15774](#15774)

- [sdk/python] Wait only for pending outputs in the Python SDK, not all
pending asyncio tasks
  [#15744](#15744)


### Miscellaneous

- [sdk/nodejs] Reorganize function serialization tests
  [#15753](#15753)

- [sdk/nodejs] Move mockpackage tests to closure integration tests
  [#15757](#15757)
@MJLongstreth-tiq MJLongstreth-tiq mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frassle Frassle Frassle approved these changes

Assignees
No one assigned
Labels
area/codegen SDK-gen, program-gen, convert language/dotnet language/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[program-gen/go,dotnet] Objects expressions assigned to properties of type Any result in incorrect programs
3 participants
@Zaid-Ajaj @pulumi-bot @Frassle