Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run NodeJS conformance tests in parallel #16078

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Apr 27, 2024

Had to make a fix in the test runner to not do sdk-gen in parallel, but otherwise this was a fairly simple change to the node tests.

@Frassle Frassle marked this pull request as ready for review April 27, 2024 17:58
@Frassle Frassle requested a review from a team as a code owner April 27, 2024 17:58
@Frassle Frassle added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 27, 2024
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2024-04-27)

@Frassle
Copy link
Member Author

Frassle commented Apr 27, 2024

Hopefully python is an easy change as well after this.

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/pulumi-test-language/interface.go Outdated Show resolved Hide resolved
@Frassle Frassle removed this pull request from the merge queue due to a manual request Apr 27, 2024
@Frassle Frassle enabled auto-merge April 27, 2024 20:39
@Frassle Frassle added this pull request to the merge queue Apr 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2024
@justinvp justinvp added this pull request to the merge queue Apr 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2024
@Frassle Frassle added this pull request to the merge queue Apr 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2024
@Frassle Frassle added this pull request to the merge queue Apr 28, 2024
Merged via the queue into master with commit 0063635 Apr 28, 2024
49 checks passed
@Frassle Frassle deleted the fraser/parnodetests branch April 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants