Query language runtime for options during “pulumi new” #16346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
force-pushed
the
julienp/pulumi-new-options
branch
2 times, most recently
from
5b9540f
to
10510d9
Compare
julienp
commented
Jun 7, 2024
julienp
force-pushed
the
julienp/pulumi-new-options
branch
from
10510d9
to
a66cb73
Compare
3 tasks
Frassle
reviewed
Jun 7, 2024
julienp
force-pushed
the
julienp/pulumi-new-options
branch
from
a66cb73
to
720bcdc
Compare
Allow passing runtime options as args in pulumi new
Co-authored-by: Will Jones <will@sacharissa.co.uk>
…-requirements-txt-to-pyproject-toml-when-using-poetry.yaml Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
lunaris
approved these changes
Jun 17, 2024
Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
#16346 introduced the capability to query the language runtime for additional prompts. We use this to let the user pick a package manager among npm, yarn and pnpm during `pulumi new` when using the nodejs runtime. When there is no explicitly configured package manager, we re-use the previous behaviour for determining the package manager (check `PULUMI_PREFER_YARN` env variable, look for lock files). Defaults to `npm` when running `new` in non-interactive mode.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Tentative changelog: ### Features - [sdk/go] Suggest valid attributes with similar names to unrecognised ones when validating project definitions [#16097](#16097) - [cli/new] Allow passing runtime options as args in pulumi new [#16346](#16346) - [cli/new] Query language runtime for options during “pulumi new” [#16346](#16346) - [sdk/nodejs] Detect pnpm workspaces when running pulumi install [#15525](#15525) - [sdk/nodejs] Add options to Workspace::removeStack() [#16333](#16333) - [sdk/python] Automatically convert requirements.txt to pyproject.toml when using Poetry [#16346](#16346) - [sdkgen/python] Generate TypedDict types for inputs [#15957](#15957) ### Bug Fixes - [engine] Fix a panic when ignoring wildcard values with arrays of different length [#16406](#16406) - [cli/engine] Fix --continue-on-error running indefinitely when a resource fails to be created or updated [#16371](#16371) - [cli/plugin] Fix plugin install command when plugin type is tool [#16407](#16407) - [sdk/python] Don't incorrectly emit deprecation warnings for non-deprecated properties [#16400](#16400) - [sdk/python] Handle extra CLI arguments passed policy packs plugins [#16402](#16402) - [sdk/python] Add VIRTUAL_ENV environment variable when running inside a virtual environment ### Miscellaneous - [cli/new] Instruct the user to use 'pulumi install' when using --generate-only
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 22, 2024
Waiting on #16441, but there are also a few other fixes in the queue that I'll opportunistically wait on as well. Tentative changelog: ### Features - [engine] Resolve provider in the engine before passing it to transforms [#16409](#16409) - [sdk/go] Suggest valid attributes with similar names to unrecognised ones when validating project definitions [#16097](#16097) - [cli/new] Allow passing runtime options as args in pulumi new [#16346](#16346) - [cli/new] Query language runtime for options during “pulumi new” [#16346](#16346) - [cli/new] Add packagemanager prompt to pulumi new for nodejs [#16417](#16417) - [sdk/nodejs] Detect pnpm workspaces when running pulumi install [#15525](#15525) - [sdk/nodejs] Add options to Workspace::removeStack() [#16333](#16333) - [sdk/python] Automatically convert requirements.txt to pyproject.toml when using Poetry [#16346](#16346) - [sdkgen/python] Generate TypedDict types for inputs [#15957](#15957) ### Bug Fixes - [engine] Fix a panic when ignoring wildcard values with arrays of different length [#16406](#16406) - [cli/engine] Fix --continue-on-error running indefinitely when a resource fails to be created or updated [#16371](#16371) - [sdk/nodejs] Avoid an unhandled error when `dependencies` is missing from `package.json` during closure serialization [#16433](#16433) - [cli/plugin] Fix plugin install command when plugin type is tool [#16407](#16407) - [sdk/python] Fix Python SDK docs by escaping the trailing underscore in a docstring [#14866](#14866) - [sdk/python] Don't incorrectly emit deprecation warnings for non-deprecated properties [#16400](#16400) - [sdk/python] Handle extra CLI arguments passed policy packs plugins [#16402](#16402) - [sdk/python] Add VIRTUAL_ENV environment variable when running inside a virtual environment [#16425](#16425) - [sdk/python] Don't lift dunder attributes on `Output`s ### Miscellaneous - [sdk/{go,nodejs,python}] Add register resource transform alias for register stack transform - [cli/new] Instruct the user to use 'pulumi install' when using --generate-only [#16411](#16411)
|
This PR has been shipped in release v3.121.0. |
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16309
During
pulumi newwe query the language runtime using the newRuntimeOptionsPromptsRPC call to get additional prompts to ask the user.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumpt