Parallelize Construct and Call calls in the Node.js SDK #16427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to global state issues in the nodejs runtime, we serialized MLC construct requests in #6452. This had the downside that cloud resources were not created in parallel if multiple instances of the same component were instantiated in the same program. This change removes the serialization of Construct and Call calls. The global state issues were already fixed in #10568
Changelog[uncommitted] (2024-06-20)Features
|
|
I still need to figure out how to properly test this. There's existing tests covering this code (including the uncaught error handler), but I'd like to create a test that tests the parallel execution of MLC construct requests and Call requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to global state issues in the nodejs runtime, we serialized MLC construct requests in #6452.
This had the downside that cloud resources were not created in parallel if multiple instances of the same component were instantiated in the same program.
This change removes the serialization of Construct and Call calls.
The global state issues were already fixed in #10568
Fixes #7629
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change