Reworked gen-bash-completion into a more generic completion command
#1967
Conversation
|
I'm sorry I don't really get why the build is failing and I have a hard time making Gometalinter work locally. |
I pushed a commit to your branch that addresses the linter issues. |
We don't appear to use it ourselves, so I think it's safe to make this change. |
|
Thanks for the lint fix, I thought I didn't need to handle errors on print functions but it makes sense. |
There was a problem hiding this comment.
Thanks Tirke!
I believe the only place this is used currently is in the docs at
https://github.com/pulumi/docs/blob/f426b531e461c62ec7c55ca884dcc6b133aca9bb/reference/commands.md
If you want to send a PR there for the changes to adapt to this that would be great!
cmd/completion.go
Outdated
| // It is hidden by default since it's not commonly used outside of our own build processes. | ||
| func newCompletionCmd(root *cobra.Command) *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "completion <SHELL>", |
There was a problem hiding this comment.
Perhaps we should keep this command name closer to the original - gen-completion?
Why ?
I'm using Zsh (and I'm not the only one 🤣). Pulumi having Zsh completions is great. I will also add completions to the Homebrew Formula when this is merged.
Why not use Cobra
GenZshCompletionIt's currently not good enough. Maybe it will be when spf13/cobra#646 is done.
Implementation
I did the same thing
kubectldoes for Zsh completion. Meaning using the bash completion generated by Cobra and adapting it to a zsh format. The resulting zsh completion file is not perfect (compared to one's where you have a short command description in the output) but it's good enough I think.I also changed the file output to a stdout output. I think it's better than outputting to a file and it will make adding completions in Homebrew straightforward. I don't know if the previous
gen-bash-completionis used in any Pulumi project so this may break things.