dotnet language provider #2003
dotnet language provider #2003
Conversation
|
Awesome! Thanks for the PR. We'll review this soon, and then we can figure out the next steps for landing this. |
sdk/dotnet/Pulumi/Error.cs
Outdated
| /// RunError can be used for terminating a program abruptly, but resulting in a clean exit rather than the usual | ||
| /// verbose unhandled error logic which emits the source program text and complete stack trace. | ||
| /// </summary> | ||
| public class RunError : ApplicationException { |
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/dotnet/api/system.applicationexception?view=netcore-2.1#remarks
You should derive custom exceptions from the Exception class rather than the ApplicationException class. You should not throw an ApplicationException exception in your code, and you should not catch an ApplicationException exception unless you intend to re-throw the original exception.
Naming wise, exception types typically end with Exception? i.e. RunErrorException?
|
|
||
| public class ComponentResource : Resource | ||
| { | ||
| public ComponentResource(string type, string name, ResourceOptions opts = default(ResourceOptions)) |
There was a problem hiding this comment.
default(ResourceOptions) can just be default if using C#7.1 or later
sdk/dotnet/Pulumi/Config.cs
Outdated
| } | ||
|
|
||
| public Config(string name) { | ||
| m_prefix = name; |
There was a problem hiding this comment.
So this might just be my opinion man but I'm going to argue the m_ prefix is not typically used in c# :)
https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md
https://github.com/aspnet/AspNetCore/wiki/Engineering-guidelines#coding-guidelines
|
@damianh, will change the exception type. I'll leave the pulumi guys to comment on their preference for m_ or not. |
|
Did I read this right, this will be usable by any .Net language like F#? |
|
@7sharp9 yes it's just going to be a netstandard 2 library and use "dotnet run" to execute the pulumi programs. |
|
@Frassle is this dead or are you still moving forward on it? |
|
I've put this on hold while waiting for a resolution to #2430. If Pulumi decides to support multi-language I'll pick this back up. |
|
I was excited to see this come to fruition and hope it happens in the future. |
|
👍 We use Cake extensively for our .NET Builds (https://cakebuild.net/ ) , so having .NET support would make it a great fit for us. |
|
Closed in favor of #3399 |
Very experimental first pass at dotnet support. Got it working with tfgen such that I can do some simple updates. For sure not every pulumi feature is working.