Use math.MaxInt32 to signal unbounded parallelism #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downlevel versions of the Pulumi Node SDK assumed that a parallelism level of zero implied serial execution, which current CLIs use to signal unbounded parallelism. This commit works around the downlevel issue by using math.MaxInt32 to signal unbounded parallelism.
pgavlin
reviewed
Oct 29, 2018
| @@ -133,7 +133,7 @@ func newDestroyCmd() *cobra.Command { | |||
| "Display operation as a rich diff showing the overall change") | |||
| cmd.PersistentFlags().IntVarP( | |||
| ¶llel, "parallel", "p", defaultParallel, | |||
| "Allow P resource operations to run in parallel at once (1 for no parallelism, 0 for unbounded parallelism)") | |||
| "Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.") | |||
There was a problem hiding this comment.
Can we keep the command-line option's behavior the same and just tweak this internally?
ellismg
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downlevel versions of the Pulumi Node SDK assumed that a parallelism
level of zero implied serial execution, which current CLIs use to signal
unbounded parallelism. This commit works around the downlevel issue by
using math.MaxInt32 to signal unbounded parallelism.
Fixes #2108.