Add support for explicit delete-before-replace #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a new flag to the various `ResourceOptions` types that indicates that a resource should be deleted before it is replaced, even if the provider does not require this behavior. The usual delete-before-replace cascade semantics apply. Fixes #1620.
swgillespie
reviewed
Jan 31, 2019
| @@ -182,7 +182,8 @@ def do_resolve(value: Any, perform_apply: bool, exn: Optional[Exception]): | |||
| protect=opts.protect, | |||
| provider=resolver.provider_ref, | |||
| dependencies=resolver.dependencies, | |||
| propertyDependencies=property_dependencies | |||
| propertyDependencies=property_dependencies, | |||
| deleteBeforeReplace=opts.delete_before_replace | |||
There was a problem hiding this comment.
can you add a test for this?
There was a problem hiding this comment.
sure--what sort? just a unit test to ensure that it's passed appropriately?
There was a problem hiding this comment.
yep, something simple like that.
There was a problem hiding this comment.
(I had a bug with opts.protect where it didn't get passed, so I'm hoping to get good test coverage on fundamentals like passing opts to the engine 😆 )
|
Please update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new flag to the various
ResourceOptionstypes thatindicates that a resource should be deleted before it is replaced, even
if the provider does not require this behavior. The usual
delete-before-replace cascade semantics apply.
Fixes #1620.