Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on pulumi-master instead of master for pulumi/glog #2997

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Depend on pulumi-master instead of master for pulumi/glog #2997

merged 2 commits into from
Jul 29, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jul 29, 2019

Fixes #2989.

@jen20 jen20 requested a review from lukehoban July 29, 2019 17:26
lukehoban
lukehoban approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust that this does what it says it does :-).

@jen20
Copy link
Contributor Author

jen20 commented Jul 29, 2019

One way we can tell that is the case is that there is no new go.sum entry - indicating we are depending on a version we have previously depended on, which adds a fix for the presenting condition of #2989.

@jen20 jen20 merged commit d1d2aff into master Jul 29, 2019
@pulumi-bot pulumi-bot deleted the jen20/glog-branch branch July 29, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: logging before flag.Parse: on log lines and nodejs language plugin shuts down poorly
2 participants
@jen20 @lukehoban