-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print a Welcome to Pulumi message #3145
Conversation
Present a warm welcome to users on their first ever login. Also use this as an opportunity to present a "Tip of the Day" - which for now we will use to highlight auto-naming as this has been a common new user question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say "suffix" and not "postfix" but LGTM otherwise.
pkg/backend/httpstate/backend.go
Outdated
fmt.Printf("\n") | ||
fmt.Print(opts.Color.Colorize(colors.SpecSubHeadline + " Tip of the day: " + colors.Reset)) | ||
fmt.Printf("Resources you create with Pulumi are given unique names (a randomly" + "\n") | ||
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or to customize this" + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I think in prose we should use the term "suffix" and not "postfix" but if we use "postfix" elsewhere then I guess that's fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
Btw @joeduffy @cnunciato and @bermudezmt would love your eyes on the text here overall in case we can make this generally more of a warm and inviting (+ helpful) welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it FWIW.
I do think it's worth reconciling with the get.pulumi.com script, since I think that nudges you to get-started also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we just went with "Get started with Pulumi: " for the installation scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: alignment with get.pulumi.com
- we do indeed end that script with:
say_green "+ Get started with Pulumi: https://www.pulumi.com/docs/quickstart"
So there is a sense in which we will repeat this message along the path of "curl to download" then "run pulumi new
or similar".
However, for brew
users - which I suspect represents at least half of our end user new installs, they won't have seen the get.pulumi.com
message.
I'm not sure of any better alignment that makes sense here - except to possibly expand the text around this in the welcome message a little more. If there are any immediate suggestions on that happy to take them, else this is something we can likely continue to improve going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for cleaning up the code. This kinda seems like a hack, but given the shape of the APIs we have right now, this might be the best we can do.
Could you file an issue in the service repo so we can return this data in a more first-class way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - love the tip of the day!
pkg/backend/httpstate/backend.go
Outdated
fmt.Printf("\n") | ||
fmt.Print(opts.Color.Colorize(colors.SpecSubHeadline + " Tip of the day: " + colors.Reset)) | ||
fmt.Printf("Resources you create with Pulumi are given unique names (a randomly" + "\n") | ||
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or to customize this" + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we just went with "Get started with Pulumi: " for the installation scripts.
pkg/backend/httpstate/backend.go
Outdated
fmt.Printf("\n") | ||
fmt.Print(opts.Color.Colorize(colors.SpecSubHeadline + " Tip of the day: " + colors.Reset)) | ||
fmt.Printf("Resources you create with Pulumi are given unique names (a randomly" + "\n") | ||
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or to customize this" + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or to customize this" + "\n") | |
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or customizing a resource name," + "\n") |
pkg/backend/httpstate/backend.go
Outdated
fmt.Print(opts.Color.Colorize(colors.SpecSubHeadline + " Tip of the day: " + colors.Reset)) | ||
fmt.Printf("Resources you create with Pulumi are given unique names (a randomly" + "\n") | ||
fmt.Printf(" generated postfix) by default. To learn more about auto-naming or to customize this" + "\n") | ||
fmt.Printf(" see: https://www.pulumi.com/docs/intro/concepts/programming-model/#autonaming." + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt.Printf(" see: https://www.pulumi.com/docs/intro/concepts/programming-model/#autonaming." + "\n") | |
fmt.Printf(" see https://www.pulumi.com/docs/intro/concepts/programming-model/#autonaming." + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also love it! (Agree "suffix" is clearer, too.)
Instead of showing the message only on the first-ever login, instead show on all interactive logins. We'll lean into the "Tip of the day" aspect here instead of the "thank you for signing up" aspect.
Present a warm welcome to users when they interactively login.
Also use this as an opportunity to present a "Tip of the Day" - which for now we will use to highlight auto-naming as this has been a common new user question.
Shown during a
![Screen Shot 2019-08-26 at 4 18 15 PM](https://user-images.githubusercontent.com/223467/63732026-0a15ee80-c827-11e9-9900-cd480c558ee0.png)
pulumi login
:Shown during a
![Screen Shot 2019-08-26 at 4 17 29 PM](https://user-images.githubusercontent.com/223467/63732027-0a15ee80-c827-11e9-9a38-e9dea553abf4.png)
pulumi new
: