Do not drop unhandled exceptions in Python #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add test coverage of key scenarios here? |
Yep—working on that now. |
lukehoban
reviewed
Sep 3, 2019
ellismg
reviewed
Sep 3, 2019
ellismg
reviewed
Sep 3, 2019
- Do not use a non-zero-to-zero transition in the number of outstanding RPCs to determine the completion of a Python program until after the synchronous piece of the program has finished running is complete - Instead of using a future to indicate that either a) a zero-to-one transition in the number of outstanding RPCs has occurred, or b) an unhandled exception has occurred, a) observe the transition itself, and b) use an optional exception field to track the presence or absence of an exception. Fixes #3162.
pgavlin
force-pushed
the
pgavlin/pythonException
branch
from
aee0b42
to
261f107
Compare
pgavlin
changed the title
lukehoban
pushed a commit
that referenced
this pull request
Sep 7, 2019
- Do not use a non-zero-to-zero transition in the number of outstanding RPCs to determine the completion of a Python program until after the synchronous piece of the program has finished running is complete - Instead of using a future to indicate that either a) a zero-to-one transition in the number of outstanding RPCs has occurred, or b) an unhandled exception has occurred, a) observe the transition itself, and b) use an optional exception field to track the presence or absence of an exception. Fixes #3162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPCs to determine the completion of a Python program until after the
synchronous piece of the program has finished running is complete
transition in the number of outstanding RPCs has occurred, or b) an
unhandled exception has occurred, a) observe the transition itself,
and b) use an optional exception field to track the presence or
absence of an exception.
Fixes #3162.