GH-2319: Increase the grpc.MaxCallRecvMsgSize #3201
Conversation
stack72
force-pushed
the
stack72/raise-grpc-max-message-size
branch
from
771d813
to
b8fa891
Compare
pkg/resource/plugin/plugin.go
Outdated
| @@ -55,6 +55,9 @@ type plugin struct { | |||
| // pluginRPCConnectionTimeout dictates how long we wait for the plugin's RPC to become available. | |||
| var pluginRPCConnectionTimeout = time.Second * 10 | |||
|
|
|||
| // pluginRPCMaxMessageSize raises the gRPC Max Message size from `4194304` to `8388608` | |||
| var pluginRPCMaxMessageSize = 1024 * 1024 * 8 | |||
There was a problem hiding this comment.
Why 2x vs say 100x?
Seems 2x won’t make a huge dent in how common it is to hit this.
Also - since we are doing gRPC within a single machine - I assume we are generally less sensitive to issues related to this limit?
There was a problem hiding this comment.
I was trying to be kinda conservative :D
The userdata limit is 16KB, anything higher than that and AWS will reject it anyway. If you want, I can of course make it 1024*1024*100 - I am happy to do that if you want
There was a problem hiding this comment.
Yeah, we might as well make this pretty large if there are no adverse effects.
pkg/resource/plugin/plugin.go
Outdated
| @@ -55,6 +55,9 @@ type plugin struct { | |||
| // pluginRPCConnectionTimeout dictates how long we wait for the plugin's RPC to become available. | |||
| var pluginRPCConnectionTimeout = time.Second * 10 | |||
|
|
|||
| // pluginRPCMaxMessageSize raises the gRPC Max Message size from `4194304` to `8388608` | |||
| var pluginRPCMaxMessageSize = 1024 * 1024 * 8 | |||
There was a problem hiding this comment.
Yeah, we might as well make this pretty large if there are no adverse effects.
stack72
force-pushed
the
stack72/raise-grpc-max-message-size
branch
from
b8fa891
to
0c518cf
Compare
|
@pgavlin yes it's only enforced ServerSide. I bumped the current value 100 times - that should see us through ;) |
Fixes: #2319
In #2319, a user is hitting the gRPC limit on the message size the
server can receive when uploading ec2 user-data
This commit doubles the limit that can be sent from
1024*1024*4to1024*1024*8