Improve tracing support. #3238
Improve tracing support. #3238
Conversation
- Add endpoints for `startUpdate` and `postEngineEventsBatch` so that spans for these invocations have proper names - Inject a tracing span when walking a plan so that resource operations are properly parented - When handling gRPC calls, inject a tracing span into the call's metadata if no span is already present so that resource monitor and engine spans are properly parented - Do not trace client gRPC invocations of the empty method so that these calls (which are used to determine server availability) do not muddy the trace. Note that I tried parenting these spans appropriately, but doing so broke the trace entirely. With these changes, the only unparented span in a typical Pulumi invocation is a single call to `getUser`. This span is unparented because that call does not have a context available. Plumbing a context into that particular call is surprisingly tricky, as it is often called by other context-less functions.
- Add support for writing trace data to a local file using Appdash - Add support for viewing Appdash traces via the CLI
cmd/pulumi.go
Outdated
| @@ -175,6 +175,7 @@ func NewPulumiCmd() *cobra.Command { | |||
| cmd.AddCommand(newPluginCmd()) | |||
| cmd.AddCommand(newVersionCmd()) | |||
| cmd.AddCommand(newHistoryCmd()) | |||
| cmd.AddCommand(newViewTraceCmd()) | |||
There was a problem hiding this comment.
Happy to hide this under the debug flag if that seems desirable.
There was a problem hiding this comment.
I wonder if there is a grouping of commands like this that are "diagnostic" commands so that we could at least move this out of the top-level?
|
Here's a screenshot from the embedded trace viewer:
|
cmd/pulumi.go
Outdated
| @@ -175,6 +175,7 @@ func NewPulumiCmd() *cobra.Command { | |||
| cmd.AddCommand(newPluginCmd()) | |||
| cmd.AddCommand(newVersionCmd()) | |||
| cmd.AddCommand(newHistoryCmd()) | |||
| cmd.AddCommand(newViewTraceCmd()) | |||
There was a problem hiding this comment.
I wonder if there is a grouping of commands like this that are "diagnostic" commands so that we could at least move this out of the top-level?
Co-Authored-By: Luke Hoban <luke@pulumi.com>
There might be. For now I'm going to move this under the debug flag so that it doesn't clutter the help. |
This is a combination of two commits. The first commit fixes a number of
nagging issues with unparented spans; the second adds the ability to write
trace data to a file and view the result using the CLI.
Fix some tracing issues.
startUpdateandpostEngineEventsBatchso thatspans for these invocations have proper names
are properly parented
metadata if no span is already present so that resource monitor and
engine spans are properly parented
calls (which are used to determine server availability) do not muddy
the trace. Note that I tried parenting these spans appropriately, but
doing so broke the trace entirely.
With these changes, the only unparented span in a typical Pulumi
invocation is a single call to
getUser. This span is unparentedbecause that call does not have a context available. Plumbing a context
into that particular call is surprisingly tricky, as it is often called
by other context-less functions.
Make tracing support more flexible.