Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch CLI verisons from Homebrew where applicable. #3290

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Oct 1, 2019

If the CLI seems to have been installed using Homebrew, do not consult
the service for the latest version. Instead, consult the Homebrew JSON
API.

Fixes #3230.

If the CLI seems to have been installed using Homebrew, do not consult
the service for the latest version. Instead, consult the Homebrew JSON
API.

Fixes #3230.
@pgavlin
Copy link
Member Author

pgavlin commented Oct 1, 2019

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about caching and a nit, but LGTM otherwise.

cmd/pulumi.go Outdated Show resolved Hide resolved
cmd/pulumi.go Outdated Show resolved Hide resolved
pgavlin and others added 2 commits October 1, 2019 12:22
Co-Authored-By: Justin Van Patten <jvp@justinvp.com>
cmd/pulumi.go Show resolved Hide resolved
@pgavlin pgavlin merged commit ecd0281 into master Oct 1, 2019
@pulumi-bot pulumi-bot deleted the pgavlin/brewVersion branch October 1, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version number should come from brew
2 participants