Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an experimental pulumi watch command #3391

Merged
merged 20 commits into from
Nov 6, 2019
Merged

Add an experimental pulumi watch command #3391

merged 20 commits into from
Nov 6, 2019

Conversation

lukehoban
Copy link
Member

@lukehoban lukehoban commented Oct 22, 2019 •
edited
Loading

Adds a new experimental pulumi watch CLI command which can be used for inner loop development on a Pulumi stack. This command is only available currently via PULUMI_EXPERIMENTAL=true while in active development.

The watch command does the following:

  1. Watches the workspace (the tree rooted at the Pulumi.yaml file) for changes
  2. Triggers an update to the stack whenever there is a change
  3. Streams output containing summaries of key update events as well as logs from any resources under management into a combined CLI output

Part of #3448.

An example of current experience:

Watch - Preview 2019-11-03 12_14_45

@lukehoban lukehoban changed the title Add a pulumi watch command Add an experimental pulumi watch command Nov 3, 2019
@lukehoban
Appease linter
9cc1220
@lukehoban
Add PULUMI_EXPERIMENTAL
773d226 
Adds a PULUMI_EXPERIMENTAL flag and makes `watch`, `query` and `policy` available under the new flag (leaving the later two also available under `PULUMI_DEBUG_COMMANDS` for now).
@lukehoban
Fix help text
084f9ee
@lukehoban lukehoban mentioned this pull request Nov 5, 2019
Open
8 tasks
@lukehoban lukehoban marked this pull request as ready for review November 5, 2019 15:06
justinvp
justinvp approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Some questions/suggestions, but LGTM otherwise.

cmd/watch.go Outdated Show resolved Hide resolved
pkg/backend/display/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
cmd/watch.go Outdated Show resolved Hide resolved
pgavlin
pgavlin reviewed Nov 6, 2019
View reviewed changes
pkg/backend/display/watch.go Outdated Show resolved Hide resolved
pkg/backend/watch.go Show resolved Hide resolved
@lukehoban lukehoban added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 6, 2019
@lukehoban lukehoban removed the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 6, 2019
@pgavlin pgavlin merged commit 25206c5 into master Nov 6, 2019
@pulumi-bot pulumi-bot deleted the lukehoban/watch branch November 6, 2019 20:56
@dz-pyps
Copy link

dz-pyps commented Nov 7, 2019

This feature is amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukehoban @dz-pyps @justinvp @pgavlin