Reimplement Output for Go. #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a mutex + condition variable instead of a channel for synchronizaiton in order to allow multiple calls to resolve/reject - Properly handle outputs that are resolved to other outputs, especially if those outputs are not of exactly type *Output - Remove the Value() methods that allowed prompt access to output values - Add variants of `Apply` that take a context parameter - Ensure that resource outputs properly incorporate their resource as a dependency
pgavlin
force-pushed
the
pgavlin/goOutput
branch
from
8b5a62f
to
dd572e1
Compare
EvanBoyle
reviewed
Nov 12, 2019
EvanBoyle
reviewed
Nov 12, 2019
Uninitialized outputs will be treated as resolved and unknown. This makes conversions between output types more ergonomic.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synchronizaiton in order to allow multiple calls to resolve/reject
if those outputs are not of exactly type *Output
Applythat take a context parametera dependency
Contributes to #3492.