Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Core SDK to pulumi/pulumi container #3616

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

chrsmith
Copy link
Contributor

@chrsmith chrsmith commented Dec 8, 2019

This PR updates the pulumi/pulumi docker image to include the .NET Core SDK. This will fix pulumi/actions#19 and allow you to run .NET-based Pulumi programs using GitHub Actions.

The PR also adds some Go-based integration tests to sanity check deploying Pulumi programs using the container. However, they are disabled by default since they require a PULUMI_ACCESS_TOKEN and I'm not sure if we have any way to avoid it getting disclosed into CI/CD logs.

Do we have a solution for this? As it would be nice to run these tests during scripts/build-and-publish-docker (after the containers have been built locally, but before they are pushed to DockerHub).

apt-get update -y && \
apt-get install -y \
apt-transport-https \
dotnet-sdk-3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the recently released 3.1 makes sense to me as that's the LTS version. However, we should probably move to using it everywhere else first, right? https://github.com/pulumi/scripts/blob/ae6f56d5f37fb5ac0bc232d746a768b137f21943/ci/install-common-toolchain.sh#L87-L99

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any objection, but I'd love for @pgavlin to weigh in. Since one is the "runtime dependency for Pulumi apps users are running" and the other is a "developer-machine dependency" we are installing when building Pulumi locally.

Having the versions be different is probably asking for trouble. But it might also lead to unintended consequences. But upgrading the .NET SDK we use to the LTS version seems like a general thing we should be doing. Right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll drop this down to 3.0 to match everything else for the time being, thanks Justin.

@pgavlin
Copy link
Member

pgavlin commented Dec 13, 2019

I'm not sure if we have any way to avoid it getting disclosed into CI/CD logs.

We already rely on Travis to blind secrets. I don't think we're adding risk by passing the token into the container.

@chrsmith chrsmith force-pushed the chrsmith/test-docker-containers branch from 4051cba to a5db4ba Compare December 17, 2019 16:38
@chrsmith chrsmith force-pushed the chrsmith/test-docker-containers branch from 30d1247 to c07db5c Compare December 17, 2019 17:57
@chrsmith chrsmith merged commit 7818c21 into master Dec 17, 2019
@pulumi-bot pulumi-bot deleted the chrsmith/test-docker-containers branch December 17, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: could not find dotnet on the $PATH: exec: "dotnet": executable file not found in $PATH
3 participants